update types

Author: ricardo-devis-agullo

src/registry/domain/validators/component-parameters.ts

@@ -30,7 +30,7 @@ interface ValidationResult {
 export default function componentParameters(
   requestParameters: Dictionary<string | number | boolean>,
   expectedParameters: Dictionary<OcParameter> = {}
-) {
+): ValidationResult {
   const result: ValidationResult = { isValid: true, errors: {} };
   const mandatoryParameters: string[] = [];
 
@@ -45,6 +45,7 @@ export default function componentParameters(
   for (const mandatoryParameterName of mandatoryParameters) {
     if (
       typeof requestParameters === 'object' &&
+      // eslint-disable-next-line no-prototype-builtins
       !requestParameters.hasOwnProperty(mandatoryParameterName)
     ) {
       if (!result.errors.mandatory) {
@@ -62,6 +63,7 @@ export default function componentParameters(
   )) {
     if (
       typeof expectedParameters === 'object' &&
+      // eslint-disable-next-line no-prototype-builtins
       expectedParameters.hasOwnProperty(requestParameterName)
     ) {
       const expectedType = expectedParameters[requestParameterName].type;

src/registry/domain/validators/index.ts

@@ -9,10 +9,8 @@ import registryConfigurationValidator from './registry-configuration';
 import uploadedPackageValidator from './uploaded-package';
 import nodeVersionValidator from './node-version';
 
-export function validateComponentName(componentName: string) {
-  return (
-    !/[^a-zA-Z0-9\-\_]/.test(componentName) && componentName !== '_package'
-  );
+export function validateComponentName(componentName: string): boolean {
+  return !/[^a-zA-Z0-9\-_]/.test(componentName) && componentName !== '_package';
 }
 export const validateComponentParameters = componentParametersValidator;
 export const validateNodeVersion = nodeVersionValidator;
@@ -21,6 +19,6 @@ export const validatePackage = uploadedPackageValidator;
 export const validatePackageJson = packageJsonValidator;
 export const validatePluginsRequirements = pluginsRequirementsValidator;
 export const validateRegistryConfiguration = registryConfigurationValidator;
-export function validateVersion(version: string) {
+export function validateVersion(version: string): boolean {
   return !!semver.valid(version);
 }

src/registry/domain/validators/plugins-requirements.ts

@@ -7,13 +7,19 @@ type ValidationResult =
   | { isValid: false; missing: string[] };
 
 export default function pluginsRequirements(
-  componentRequirements: string[],
+  componentRequirements:
+    | Record<string, (...args: unknown[]) => unknown>
+    | string[]
+    | null
+    | undefined,
   registryPlugins: Config['plugins']
 ): ValidationResult {
-  const result = { isValid: true };
   const missing: string[] = [];
+  const requiredPlugins = Array.isArray(componentRequirements)
+    ? componentRequirements
+    : Object.keys(componentRequirements || {});
 
-  for (const requiredPlugin of componentRequirements || []) {
+  for (const requiredPlugin of requiredPlugins) {
     if (
       !registryPlugins ||
       !Object.keys(registryPlugins).includes(requiredPlugin)

src/registry/domain/validators/registry-configuration.ts

@@ -4,7 +4,9 @@ import { Config } from '../../../types';
 
 type ValidationResult = { isValid: true } | { isValid: false; message: string };
 
-export default function registryConfiguration(conf: Config): ValidationResult {
+export default function registryConfiguration(
+  conf: Partial<Config>
+): ValidationResult {
   const returnError = (message: string): ValidationResult => {
     return {
       isValid: false,
@@ -69,10 +71,10 @@ export default function registryConfiguration(conf: Config): ValidationResult {
         );
       }
 
-      if (route.route.indexOf(prefix) === 0) {
+      if (route.route.indexOf(prefix || '') === 0) {
         return returnError(
           strings.errors.registry.CONFIGURATION_ROUTES_ROUTE_CONTAINS_PREFIX(
-            prefix
+            prefix || ''
           )
         );
       }

src/registry/domain/validators/uploaded-package.ts

@@ -1,5 +1,3 @@
-import _ from 'lodash';
-
 type ValidationResponse =
   | {
       isValid: true;
@@ -16,7 +14,7 @@ export default function uploadedPackage(
         [fieldname: string]: Express.Multer.File[];
       }
 ): ValidationResponse {
-  const returnError = function(message): ValidationResponse {
+  const returnError = function(message?: string): ValidationResponse {
     return {
       isValid: false,
       message: message || 'uploaded package is not valid'
@@ -31,7 +29,7 @@ export default function uploadedPackage(
     return returnError('not_valid');
   }
 
-  const file = input[0];
+  const file: Express.Multer.File = (input as any)[0];
   const validTypes = ['application/gzip', 'application/octet-stream'];
 
   if (