Merge pull request #1264 from opencomponents/remove-lodash-typeof-checks

[INTERNAL] Replace lodash type checkers with typeof

Author: ricardo-devis-agullo

src/cli/facade/dev.ts

@@ -38,10 +38,9 @@ const dev =
     const port = opts.port || 3000;
     const baseUrl = opts.baseUrl || `http://localhost:${port}/`;
     const fallbackRegistryUrl = opts.fallbackRegistryUrl;
-    const hotReloading = _.isUndefined(opts.hotReloading)
-      ? true
-      : opts.hotReloading;
-    const optWatch = _.isUndefined(opts.watch) ? true : opts.watch;
+    const hotReloading =
+      typeof opts.hotReloading === 'undefined' ? true : opts.hotReloading;
+    const optWatch = typeof opts.watch === 'undefined' ? true : opts.watch;
     let packaging = false;
 
     const watchForChanges = function (
@@ -71,7 +70,7 @@ const dev =
       componentsDirs: string[],
       optCb?: () => void
     ) => {
-      const cb = _.isFunction(optCb) ? optCb : _.noop;
+      const cb = typeof optCb === 'function' ? optCb : _.noop;
 
       let i = 0;
 

src/registry/domain/options-sanitiser.ts

@@ -37,28 +37,28 @@ export default function optionsSanitiser(input: Input): Config {
     options.tempDir = settings.registry.defaultTempPath;
   }
 
-  if (!_.isBoolean(options.hotReloading)) {
+  if (typeof options.hotReloading !== 'boolean') {
     options.hotReloading = !!options.local;
   }
 
-  if (_.isUndefined(options.verbosity)) {
+  if (!options.verbosity) {
     options.verbosity = 0;
   }
 
-  if (_.isUndefined(options.discovery)) {
+  if (typeof options.discovery === 'undefined') {
     options.discovery = true;
   }
 
-  if (_.isUndefined(options.pollingInterval)) {
+  if (typeof options.pollingInterval === 'undefined') {
     options.pollingInterval = 5;
   }
 
-  if (_.isUndefined(options.templates)) {
+  if (!options.templates) {
     options.templates = [];
   }
 
   if (
-    !_.isUndefined(options.fallbackRegistryUrl) &&
+    typeof options.fallbackRegistryUrl !== 'undefined' &&
     _.last(options.fallbackRegistryUrl) !== '/'
   ) {
     options.fallbackRegistryUrl += '/';

src/registry/domain/plugins-initialiser.ts

@@ -12,9 +12,9 @@ function validatePlugins(plugins: unknown[]): asserts plugins is Plugin[] {
     c++;
     if (
       !_.isObject((plugin as Plugin).register) ||
-      !_.isFunction((plugin as Plugin).register.register) ||
-      !_.isFunction((plugin as Plugin).register.execute) ||
-      !_.isString((plugin as Plugin).name)
+      typeof (plugin as Plugin).register.register !== 'function' ||
+      typeof (plugin as Plugin).register.execute !== 'function' ||
+      typeof (plugin as Plugin).name !== 'string'
     ) {
       throw new Error(
         strings.errors.registry.PLUGIN_NOT_VALID(

src/registry/domain/repository.ts

@@ -132,16 +132,14 @@ export default function repository(conf: Config): Repository {
       componentVersionOrCallback: string | Callback<Component, string>,
       callbackMaybe?: Callback<Component, string>
     ) {
-      const componentVersion: string | undefined = _.isFunction(
-        componentVersionOrCallback
-      )
-        ? undefined
-        : (componentVersionOrCallback as any);
-      const callback: Callback<Component, string> = _.isFunction(
-        componentVersionOrCallback
-      )
-        ? (componentVersionOrCallback as any)
-        : callbackMaybe!;
+      const componentVersion: string | undefined =
+        typeof componentVersionOrCallback === 'function'
+          ? undefined
+          : (componentVersionOrCallback as any);
+      const callback: Callback<Component, string> =
+        typeof componentVersionOrCallback === 'function'
+          ? (componentVersionOrCallback as any)
+          : callbackMaybe!;
 
       repository.getComponentVersions(componentName, (err, allVersions) => {
         if (err) {

src/registry/routes/components.ts

@@ -44,7 +44,7 @@ export default function components(
       return returnError(
         registryErrors.BATCH_ROUTE_COMPONENTS_PROPERTY_MISSING
       );
-    } else if (!_.isArray(components)) {
+    } else if (!Array.isArray(components)) {
       return returnError(registryErrors.BATCH_ROUTE_COMPONENTS_NOT_ARRAY);
     }
 

test/unit/registry-domain-nested-renderer.js

@@ -12,7 +12,7 @@ describe('registry : routes : helpers : nested-renderer', () => {
   let renderer;
 
   const initialise = function (rendererMocks, conf) {
-    if (_.isArray(rendererMocks)) {
+    if (Array.isArray(rendererMocks)) {
       renderer = sinon.stub();
 
       _.each(rendererMocks, (rendererMock, i) => {