sanitize tasks

Author: ricardo-devis-agullo

package.json

@@ -13,9 +13,9 @@
     "build": "npm run lint && tsc && node tasks/build.js",
     "git-stage-and-push": "node tasks/git-stage-and-push.js",
     "npm-publish": "node tasks/npm-publish.js",
-    "publish-major": "npm run version-major && npm run test-silent && npm run git-stage-and-push && npm run npm-publish",
-    "publish-minor": "npm run version-minor && npm run test-silent && npm run git-stage-and-push && npm run npm-publish",
-    "publish-patch": "npm run version-patch && npm run test-silent && npm run git-stage-and-push && npm run npm-publish",
+    "publish-major": "npm run test-silent && npm run version-major && npm run git-stage-and-push && npm run npm-publish",
+    "publish-minor": "npm run test-silent && npm run version-minor && npm run git-stage-and-push && npm run npm-publish",
+    "publish-patch": "npm run test-silent && npm run version-patch && npm run git-stage-and-push && npm run npm-publish",
     "test": "npm run build && node tasks/mochaTest.js",
     "test-silent": "npm run build && node tasks/mochaTest.js --silent",
     "version-major": "node tasks/version.js --type=\"major\"",

tasks/build.js

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-var-requires */
 'use strict';
 
 const fs = require('fs-extra');

tasks/changelog.js

@@ -1,12 +1,13 @@
+/* eslint-disable @typescript-eslint/no-var-requires */
 'use strict';
 
 const async = require('async');
 const fs = require('fs');
 const path = require('path');
-const get = require('./git');
+const git = require('./git');
 
 module.exports = () =>
-  new Promise(resolve => {
+  new Promise((resolve, reject) => {
     const writeChangelog = (changelog, cb) => {
       let result = '## Change Log';
       changelog.forEach(pr => {
@@ -17,12 +18,12 @@ module.exports = () =>
       fs.writeFile(path.join(__dirname, '../CHANGELOG.md'), result, cb);
     };
 
-    get.tags((err, tags) => {
+    git.tags((err, tags) => {
       const result = [];
       async.eachSeries(
         tags,
         (tag, next) => {
-          get.prs(tag, (err, changes) => {
+          git.prs(tag, (err, changes) => {
             result.push({
               tag,
               changes

tasks/git-stage-and-push.js

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-var-requires */
 'use strict';
 
 const changelog = require('./changelog');

tasks/git.js

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-var-requires */
 'use strict';
 
 const path = require('path');
@@ -76,13 +77,14 @@ const utils = {
 
 module.exports = {
   // Fetches PRs
-  prs: (options, cb) => {
-    const opts = Object.assign({}, options, {
+  prs(options, cb) {
+    const opts = {
+      ...options,
       format: {
         message: '%s',
         body: '%b'
       }
-    });
+    };
     git.log(opts, (err, changes) => {
       if (err) {
         cb(err, null);
@@ -91,7 +93,7 @@ module.exports = {
     });
   },
   // Fetches all tags
-  tags: cb => {
+  tags(cb) {
     utils.getFirstCommitHash((err, hash) => {
       git.tags((err, tags) => {
         if (err) {

tasks/logger.js

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-var-requires */
 'use strict';
 
 const chalk = require('chalk');

tasks/mochaTest.js

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-var-requires */
 'use strict';
 
 const async = require('async');

tasks/npm-publish.js

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-var-requires */
 const fs = require('fs-extra');
 const log = require('./logger');
 const spawn = require('cross-spawn');

tasks/version.js

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-var-requires */
 'use strict';
 
 const fs = require('fs-extra');
@@ -24,6 +25,6 @@ if (
   log.complete(`Package version upgraded to: ${packageJson.version}`);
 } else {
   log.error(
-    `Incorrect --type input: ${argv.type}. Use \'patch\', \'minor\' or \'major\'`
+    `Incorrect --type input: ${argv.type}. Use 'patch', 'minor' or 'major'`
   );
 }