make it fail if it can't retreive the json on load

Author: ricardo-devis-agullo

.npmignore

@@ -7,3 +7,4 @@ appveyor.yml
 Gruntfile.js
 tasks
 test
+src

src/registry/domain/components-cache/index.ts

@@ -3,7 +3,7 @@ import getComponentsList from './components-list';
 import eventsHandler from '../events-handler';
 import getUnixUTCTimestamp from 'oc-get-unix-utc-timestamp';
 import { ComponentsList, Config } from '../../../types';
-import { StorageAdapter } from 'oc-storage-adapters-utils';
+import { StorageAdapter, strings } from 'oc-storage-adapters-utils';
 
 export default function componentsCache(conf: Config, cdn: StorageAdapter) {
   let cachedComponentsList: ComponentsList;
@@ -56,9 +56,12 @@ export default function componentsCache(conf: Config, cdn: StorageAdapter) {
     },
 
     async load(): Promise<ComponentsList> {
-      const jsonComponents = await componentsList
-        .getFromJson()
-        .catch(() => null);
+      const jsonComponents = await componentsList.getFromJson().catch(err => {
+        if (err?.code === strings.errors.STORAGE.FILE_NOT_FOUND_CODE)
+          return null;
+
+        return Promise.reject(err);
+      });
       const dirComponents = await componentsList
         .getFromDirectories(jsonComponents)
         .catch(err => throwError('components_list_get', err));

test/unit/registry-domain-components-cache.js

@@ -59,11 +59,27 @@ describe('registry : domain : components-cache', () => {
   };
 
   describe('when library does not contain components.json', () => {
+    describe('when getting the json fails', () => {
+      let error;
+      before(done => {
+        mockedCdn.getJson = sinon.stub();
+        mockedCdn.getJson.rejects('FILE_ERROR');
+        initialise();
+        componentsCache
+          .load()
+          .catch(err => (error = err))
+          .finally(done);
+      });
+
+      it('should throw with the error message', () => {
+        expect(error).to.equal('FILE_ERROR');
+      });
+    });
     describe('when initialising the cache', () => {
       before(done => {
         mockedCdn.getJson = sinon.stub();
         mockedCdn.getJson.resolves({});
-        mockedCdn.getJson.onFirstCall(0).rejects('not_found');
+        mockedCdn.getJson.onFirstCall(0).rejects({ code: 'file_not_found' });
         mockedCdn.listSubDirectories = sinon.stub();
         mockedCdn.listSubDirectories.onCall(0).resolves(['hello-world']);
         mockedCdn.listSubDirectories.onCall(1).resolves(['1.0.0', '1.0.2']);