Merge branch 'master' into type-clean-require

Author: ricardo-devis-agullo

.github/workflows/node.js.yml

@@ -0,0 +1,30 @@
+# This workflow will do a clean install of node dependencies, cache/restore them, build the source code and run tests across different versions of node
+# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
+
+name: Node.js CI
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [12.x, 14.x, 16.x]
+        # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Use Node.js ${{ matrix.node-version }}
+      uses: actions/setup-node@v2
+      with:
+        node-version: ${{ matrix.node-version }}
+        cache: 'npm'
+    - run: npm ci
+    - run: npm test

CHANGELOG.md

@@ -1,6 +1,6 @@
 {
   "name": "oc",
-  "version": "0.49.2",
+  "version": "0.49.3",
   "description": "A framework for developing and distributing html components",
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",

package.json

@@ -22,7 +22,8 @@ export default function installCompiler(
     dependency,
     installPath: componentPath,
     save: false,
-    silent: true
+    silent: true,
+    usePrefix: false
   };
 
   npm.installDependency(npmOptions, err => {

src/cli/domain/handle-dependencies/install-compiler.ts

@@ -23,7 +23,8 @@ export default function installMissingDependencies(
     dependencies: missing,
     installPath: path.resolve('.'),
     save: false,
-    silent: true
+    silent: true,
+    usePrefix: true
   };
 
   npm.installDependencies(npmOptions, err => {

src/cli/domain/handle-dependencies/install-missing-dependencies.ts

@@ -22,7 +22,8 @@ export default function installTemplate(
     dependency: compiler,
     installPath: componentPath,
     isDev: true,
-    save: true
+    save: true,
+    usePrefix: false
   };
 
   logger.log(strings.messages.cli.installCompiler(compiler));

src/cli/domain/init-template/install-template.ts

@@ -1,7 +1,7 @@
 {
   "name": "oc-client",
   "description": "The OpenComponents client-side javascript client",
-  "version": "0.49.2",
+  "version": "0.49.3",
   "repository": "https://github.com/opencomponents/oc/tree/master/components/oc-client",
   "author": "Matteo Figus <[email protected]>",
   "oc": {

src/components/oc-client/package.json

@@ -8,9 +8,14 @@ const buildInstallCommand = (options: {
   installPath: string;
   save?: boolean;
   isDev?: boolean;
+  usePrefix: boolean;
 }) => {
   const args = ['install'];
 
+  if (options.usePrefix) {
+    args.push('--prefix', options.installPath);
+  }
+
   if (options.save) {
     args.push('--save-exact');
     args.push(options.isDev ? '--save-dev' : '--save');
@@ -54,7 +59,12 @@ export const init = (
 };
 
 export const installDependencies = (
-  options: { dependencies: string[]; installPath: string; silent: boolean },
+  options: {
+    dependencies: string[];
+    installPath: string;
+    silent: boolean;
+    usePrefix: boolean;
+  },
   callback: Callback<{ dest: string }, string | number>
 ): void => {
   const { dependencies, installPath, silent } = options;
@@ -75,7 +85,12 @@ export const installDependencies = (
 };
 
 export const installDependency = (
-  options: { dependency: string; installPath: string; silent?: boolean },
+  options: {
+    dependency: string;
+    installPath: string;
+    silent?: boolean;
+    usePrefix: boolean;
+  },
   callback: Callback<{ dest: string }, string | number>
 ): void => {
   const { dependency, installPath, silent } = options;

src/utils/npm-utils.ts

@@ -56,7 +56,8 @@ describe('cli : domain : handle-dependencies : install-compiler', () => {
         dependency: '[email protected]',
         installPath: '/path/to/components/component/',
         save: false,
-        silent: true
+        silent: true,
+        usePrefix: false
       });
     });
 

test/unit/cli-domain-handle-dependencies-install-compiler.js

@@ -82,7 +82,8 @@ describe('cli : domain : handle-dependencies : install-missing-dependencies', ()
         dependencies: ['[email protected]', 'underscore@latest'],
         installPath: '/path/to/oc-running',
         save: false,
-        silent: true
+        silent: true,
+        usePrefix: true
       });
     });