Skip to content

Commit ec2e3f2

Browse files
authored
send 2B structs instead of T structs in ChallengeReq (#202)
1 parent b8cc494 commit ec2e3f2

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

service/biz/enrollz_biz.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -942,7 +942,7 @@ func EnrollSwitchWithHMACChallenge(ctx context.Context, req *EnrollSwitchWithHMA
942942
for _, controlCardSelection := range req.ControlCardSelections {
943943
cardID, iakPubKey, idevidPubKey, err := verifyIdentityWithHMACChallenge(ctx, controlCardSelection, req.Deps)
944944
if err != nil {
945-
err = fmt.Errorf("%w: failed to verify Identity with HMAC Challenge: %v", ErrVerifyIdentity, err)
945+
err = fmt.Errorf("%w: failed to verify Identity with HMAC Challenge for control card %s: %v", ErrVerifyIdentity, prototext.Format(controlCardSelection), err)
946946
log.ErrorContext(ctx, err)
947947
return err
948948
}
@@ -1102,9 +1102,9 @@ func createHMACChallenge(deps TPM20Utils, fetchEKResp *FetchEKResp) (*epb.HMACCh
11021102
}
11031103

11041104
challengeReq := &epb.HMACChallenge{
1105-
HmacPubKey: tpm20.Marshal(hmacPub),
1106-
Duplicate: duplicate,
1107-
InSymSeed: inSymSeed,
1105+
HmacPubKey: tpm20.Marshal(tpm20.BytesAs2B[tpm20.TPMTPublic](tpm20.Marshal(hmacPub))),
1106+
Duplicate: tpm20.Marshal(&tpm20.TPM2BPrivate{Buffer: duplicate}),
1107+
InSymSeed: tpm20.Marshal(&tpm20.TPM2BEncryptedSecret{Buffer: inSymSeed}),
11081108
}
11091109

11101110
return challengeReq, hmacSensitive, nil

0 commit comments

Comments
 (0)