Skip to content

Commence deprecation of suppress_redundant #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
earies wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Commence deprecation of suppress_redundant #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
daecc6e
Commence deprecation of suppress_redundant
earies Sep 29, 2025
b3b8277
Regenerate stubs
earies Oct 2, 2025
aabc53c
Update proto IDL comments
earies Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 3 additions & 32 deletions MODULE.bazel.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion proto/collector/collector.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 13 additions & 11 deletions proto/gnmi/gnmi.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 5 additions & 9 deletions proto/gnmi/gnmi.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ extend google.protobuf.FileOptions {

// gNMI_service is the current version of the gNMI service, returned through
// the Capabilities RPC.
option (gnmi_service) = "0.10.0";
option (gnmi_service) = "0.11.0";

option go_package = "github.com/openconfig/gnmi/proto/gnmi";
option java_multiple_files = true;
Expand Down Expand Up @@ -302,17 +302,13 @@ message Subscription {
SubscriptionMode mode = 2; // Subscription mode to be used.
uint64 sample_interval = 3; // ns between samples in SAMPLE mode.
// Indicates whether values that have not changed should be sent in a SAMPLE
// subscription.
bool suppress_redundant = 4;
// 1. A heartbeat interval MAY be specified along with an “on change”
// subscription. NOTE: This field has been deprecated as of gNMI service
// version 0.11.0.
bool suppress_redundant = 4 [deprecated = true];
// A heartbeat interval MAY be specified along with an “on change”
// subscription - in this case, the value of the data item(s) MUST be re-sent
// once per heartbeat interval regardless of whether the value has changed or
// not.
// 2. A heartbeat_interval MAY be specified to modify the behavior of
// suppress_redundant in a sampled subscription. In this case, the
// target MUST generate one telemetry update per heartbeat interval,
// regardless of whether the suppress_redundant flag is set to true.
// This value is specified as an unsigned 64-bit integer in nanoseconds
uint64 heartbeat_interval = 5;
}

Expand Down
2 changes: 1 addition & 1 deletion proto/gnmi_ext/gnmi_ext.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion proto/target/target.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion testing/fake/proto/fake.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading