Merge pull request #10 from kolyshkin/nolintlint

kolyshkin · web-flow · commit 2a1597e8e8ad · 2025-04-23T13:48:40.000-07:00
ci: add nolintlint, fix warnings
diff --git a/.golangci.yml b/.golangci.yml
@@ -2,8 +2,9 @@
 
 linters:
   enable:
-    - gofumpt
     - errorlint
+    - gofumpt
+    - nolintlint
     - unconvert
     - unparam
 
diff --git a/fscommon/rdma.go b/fscommon/rdma.go
@@ -50,7 +50,7 @@ func readRdmaEntries(dir, file string) ([]cgroups.RdmaEntry, error) {
 	if err != nil {
 		return nil, err
 	}
-	defer fd.Close() //nolint:errorlint
+	defer fd.Close()
 	scanner := bufio.NewScanner(fd)
 	for scanner.Scan() {
 		parts := strings.SplitN(scanner.Text(), " ", 4)
diff --git a/utils.go b/utils.go
@@ -231,7 +231,7 @@ func rmdir(path string, retry bool) error {
 
 again:
 	err := unix.Rmdir(path)
-	switch err { // nolint:errorlint // unix errors are bare
+	switch err {
 	case nil, unix.ENOENT:
 		return nil
 	case unix.EINTR:

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ func readRdmaEntries(dir, file string) ([]cgroups.RdmaEntry, error) {`
`50`	`50`	`if err != nil {`
`51`	`51`	`return nil, err`
`52`	`52`	`}`
`53`		`- defer fd.Close() //nolint:errorlint`
	`53`	`+ defer fd.Close()`
`54`	`54`	`scanner := bufio.NewScanner(fd)`
`55`	`55`	`for scanner.Scan() {`
`56`	`56`	`parts := strings.SplitN(scanner.Text(), " ", 4)`