Skip to content

Commit 8f42721

Browse files
committed
config, conversion: move volume behavior to conversion
Signed-off-by: Stephen J Day <[email protected]>
1 parent d4cf636 commit 8f42721

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

config.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,6 @@ Note: Any OPTIONAL field MAY also be set to null, which is equivalent to being a
149149
- **Volumes** *object*, OPTIONAL
150150

151151
A set of directories describing where the process is likely write data specific to a container instance.
152-
Implementations SHOULD provide mounts for these locations such that application data is not written to the container's root filesystem.
153-
If a _new_ image is created from a container based on the image described by this configuration, data in these paths SHOULD NOT be included in the _new_ image.
154152
**NOTE:** This JSON structure value is unusual because it is a direct JSON serialization of the Go type `map[string]struct{}` and is represented in JSON as an object mapping its keys to an empty object.
155153

156154
- **WorkingDir** *string*, OPTIONAL

conversion.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,10 @@ A compliant configuration converter SHOULD provide a way for users to extract th
9090

9191
1. The runtime configuration does not have a corresponding field for this image field.
9292
However, converters SHOULD set the [`org.opencontainers.image.exposedPorts` annotation](#config.exposedports).
93-
2. If a converter implements conversion for this field using mountpoints, it SHOULD set the `destination` of the mountpoint to the value specified in `Config.Volumes`.
93+
2. Implementations SHOULD provide mounts for these locations such that application data is not written to the container's root filesystem.
94+
If a converter implements conversion for this field using mountpoints, it SHOULD set the `destination` of the mountpoint to the value specified in `Config.Volumes`.
95+
An implementation MAY seed the contents of the mount with data in the image at the same location.
96+
If a _new_ image is created from a container based on the image described by this configuration, data in these paths SHOULD NOT be included in the _new_ image.
9497
The other `mounts` fields are platform and context dependent, and thus are implementation-defined.
9598
Note that the implementation of `Config.Volumes` need not use mountpoints, as it is effectively a mask of the filesystem.
9699

0 commit comments

Comments
 (0)