Skip to content

Conversation

@zhouhao3
Copy link

When I modify the program in the image-tools, I found that if the Descriptors do not concrete, you can not call it, so I think it should be specific
Signed-off-by: zhouhao [email protected]

@zhouhao3 zhouhao3 changed the title Descriptors should be materialized Descriptor should be materialized Oct 26, 2016
"digest": {
"$ref": "#definitions/digest"
"config": {
"$ref": "#content-descriptor.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine shifting the descriptor properties out into their own property, but manifest-lists currently don't do that. I think you might be confusing manifestDescriptor (used in the manifest-list) with the manifest schema.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I naMaybe I'm a little problem on the naming or understand, but I think in the manifest_list.go, Descriptor is the need for specific, or else when the call will be given the wrong, like“Descriptor has no field or method validate”

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like you're talking about this Travis error from opencontainers/image-tools#51. But that's a Go compilation error; I don't see how it relates to the JSON Schema change you're proposing here.

@philips
Copy link
Contributor

philips commented Nov 17, 2016

I don't understand the reason for this change.

@zhouhao3 zhouhao3 closed this Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants