Skip to content

Commit c82a2e7

Browse files
committed
MAINTAINERS: disallow self-LGTMs
Apart from being a sign of respect to other maintainers, it also ensures that *all* pull requests get equal amounts of review -- no matter who wrote them. Maintainers should know better than to make broken patchsets, but it's also a sign of respect to the community that all pull requests have equal treatment. Signed-off-by: Aleksa Sarai <[email protected]>
1 parent 560fdc9 commit c82a2e7

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

MAINTAINERS_GUIDE.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,9 @@ All decisions are pull requests, and the relevant maintainers make
6464
decisions by accepting or refusing the pull request. Review and acceptance
6565
by anyone is denoted by adding a comment in the pull request: `LGTM`.
6666
However, only currently listed `MAINTAINERS` are counted towards the required
67-
two LGTMs.
67+
two LGTMs. In addition, if a maintainer has created a pull request, they cannot
68+
count toward the two LGTM rule (to ensure equal amounts of review for every pull
69+
request, no matter who wrote it).
6870

6971
Overall the maintainer system works because of mutual respect across the
7072
maintainers of the project. The maintainers trust one another to make decisions

0 commit comments

Comments
 (0)