libct/utils: stripRoot: rm useless HasPrefix

kolyshkin · kolyshkin · commit 259b71c042fe · 2025-02-06T19:42:35.000-08:00
Using strings.HasPrefix with strings.TrimPrefix results in doing the
same thing (checking if prefix exists) twice. In this case, using
strings.TrimPrefix right away is sufficient.

Signed-off-by: Kir Kolyshkin &lt;kolyshkin@gmail.com&gt;
diff --git a/libcontainer/utils/utils.go b/libcontainer/utils/utils.go
@@ -77,7 +77,7 @@ func stripRoot(root, path string) string {
 		path = "/"
 	case root == "/":
 		// do nothing
-	case strings.HasPrefix(path, root+"/"):
+	default:
 		path = strings.TrimPrefix(path, root+"/")
 	}
 	return CleanPath("/" + path)

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ func stripRoot(root, path string) string {`
`77`	`77`	`path = "/"`
`78`	`78`	`case root == "/":`
`79`	`79`	`// do nothing`
`80`		`- case strings.HasPrefix(path, root+"/"):`
	`80`	`+ default:`
`81`	`81`	`path = strings.TrimPrefix(path, root+"/")`
`82`	`82`	`}`
`83`	`83`	`return CleanPath("/" + path)`