@@ -7,7 +7,7 @@ features to the project. But most of your time will be spent reviewing,
77cleaning up, documenting, answering questions, justifying design
88decisions - while everyone has all the fun! But remember - the quality
99of the maintainers work is what distinguishes the good projects from the
10- great. So please be proud of your work, even the unglamourous parts,
10+ great. So please be proud of your work, even the unglamorous parts,
1111and encourage a culture of appreciation and respect for * every* aspect
1212of improving the project - not just the hot new features.
1313
@@ -53,7 +53,7 @@ All decisions affecting runc, big and small, follow the same 3 steps:
5353* Step 3: Accept (` LGTM ` ) or refuse a pull request. The relevant maintainers do
5454this (see below "Who decides what?")
5555
56- ### I'm a maintainer, should I make pull requests too?
56+ * I'm a maintainer, should I make pull requests too?*
5757
5858Yes. Nobody should ever push to master directly. All changes should be
5959made through a pull request.
@@ -62,42 +62,42 @@ made through a pull request.
6262
6363All decisions are pull requests, and the relevant maintainers make
6464decisions by accepting or refusing the pull request. Review and acceptance
65- by anyone is denoted by adding a comment in the pull request: ` LGTM ` .
65+ by anyone is denoted by adding a comment in the pull request: ` LGTM ` .
6666However, only currently listed ` MAINTAINERS ` are counted towards the required
6767two LGTMs.
6868
6969Overall the maintainer system works because of mutual respect across the
7070maintainers of the project. The maintainers trust one another to make decisions
71- in the best interests of the project. Sometimes maintainers can disagree and
71+ in the best interests of the project. Sometimes maintainers can disagree and
7272this is part of a healthy project to represent the point of views of various people.
73- In the case where maintainers cannot find agreement on a specific change the
74- role of a Chief Maintainer comes into play.
73+ In the case where maintainers cannot find agreement on a specific change the
74+ role of a Chief Maintainer comes into play.
7575
76- The Chief Maintainer for the project is responsible for overall architecture
77- of the project to maintain conceptual integrity. Large decisions and
78- architecture changes should be reviewed by the chief maintainer.
79- The current chief maintainer for the project is Michael Crosby (@crosbymichael ).
76+ The Chief Maintainer for the project is responsible for overall architecture
77+ of the project to maintain conceptual integrity. Large decisions and
78+ architecture changes should be reviewed by the chief maintainer.
79+ The current chief maintainer for the project is Michael Crosby (@crosbymichael ).
8080
8181Even though the maintainer system is built on trust, if there is a conflict
82- with the chief maintainer on a decision, their decision can be challenged
83- and brought to the technical oversight board if two-thirds of the
84- maintainers vote for an appeal. It is expected that this would be a
82+ with the chief maintainer on a decision, their decision can be challenged
83+ and brought to the technical oversight board if two-thirds of the
84+ maintainers vote for an appeal. It is expected that this would be a
8585very exceptional event.
8686
8787
8888### How are maintainers added?
8989
9090The best maintainers have a vested interest in the project. Maintainers
9191are first and foremost contributors that have shown they are committed to
92- the long term success of the project. Contributors wanting to become
93- maintainers are expected to be deeply involved in contributing code,
92+ the long term success of the project. Contributors wanting to become
93+ maintainers are expected to be deeply involved in contributing code,
9494pull request review, and triage of issues in the project for more than two months.
9595
96- Just contributing does not make you a maintainer, it is about building trust
96+ Just contributing does not make you a maintainer, it is about building trust
9797with the current maintainers of the project and being a person that they can
9898depend on and trust to make decisions in the best interest of the project. The
9999final vote to add a new maintainer should be approved by over 66% of the current
100- maintainers with the chief maintainer having veto power. In case of a veto,
100+ maintainers with the chief maintainer having veto power. In case of a veto,
101101conflict resolution rules expressed above apply. The voting period is
102102five business days on the Pull Request to add the new maintainer.
103103
0 commit comments