Skip to content

Commit 9393700

Browse files
committed
libcontainer/intelrdt: update code comments
Use the term "clos group" instead of "container_id group" as the group that a container belongs to is not necessarily tied to its container id. Signed-off-by: Markus Lehtonen <[email protected]>
1 parent 1b4c30f commit 9393700

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

libcontainer/intelrdt/intelrdt.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ import (
7272
* |-- ...
7373
* |-- schemata
7474
* |-- tasks
75-
* |-- <container_id>
75+
* |-- <clos>
7676
* |-- ...
7777
* |-- schemata
7878
* |-- tasks
@@ -155,7 +155,7 @@ type Manager interface {
155155
// Returns statistics for Intel RDT
156156
GetStats() (*Stats, error)
157157

158-
// Destroys the Intel RDT 'container_id' group
158+
// Destroys the Intel RDT container-specific 'container_id' group
159159
Destroy() error
160160

161161
// Returns Intel RDT path to save in a state file and to be able to
@@ -517,7 +517,7 @@ func IsMBAScEnabled() bool {
517517
return mbaScEnabled
518518
}
519519

520-
// Get the 'container_id' path in Intel RDT "resource control" filesystem
520+
// Get the path of the clos group in "resource control" filesystem that the container belongs to
521521
func (m *intelRdtManager) getIntelRdtPath() (string, error) {
522522
rootPath, err := getIntelRdtRoot()
523523
if err != nil {
@@ -567,7 +567,7 @@ func (m *intelRdtManager) Apply(pid int) (err error) {
567567
return nil
568568
}
569569

570-
// Destroys the Intel RDT 'container_id' group
570+
// Destroys the Intel RDT container-specific 'container_id' group
571571
func (m *intelRdtManager) Destroy() error {
572572
// Don't remove resctrl group if closid has been explicitly specified. The
573573
// group is likely externally managed, i.e. by some other entity than us.
@@ -614,7 +614,7 @@ func (m *intelRdtManager) GetStats() (*Stats, error) {
614614
}
615615
schemaRootStrings := strings.Split(tmpRootStrings, "\n")
616616

617-
// The L3 cache and memory bandwidth schemata in 'container_id' group
617+
// The L3 cache and memory bandwidth schemata in container's clos group
618618
containerPath := m.GetPath()
619619
tmpStrings, err := getIntelRdtParamString(containerPath, "schemata")
620620
if err != nil {
@@ -637,7 +637,7 @@ func (m *intelRdtManager) GetStats() (*Stats, error) {
637637
}
638638
}
639639

640-
// The L3 cache schema in 'container_id' group
640+
// The L3 cache schema in container's clos group
641641
for _, schema := range schemaStrings {
642642
if strings.Contains(schema, "L3") {
643643
stats.L3CacheSchema = strings.TrimSpace(schema)
@@ -660,7 +660,7 @@ func (m *intelRdtManager) GetStats() (*Stats, error) {
660660
}
661661
}
662662

663-
// The memory bandwidth schema in 'container_id' group
663+
// The memory bandwidth schema in container's clos group
664664
for _, schema := range schemaStrings {
665665
if strings.Contains(schema, "MB") {
666666
stats.MemBwSchema = strings.TrimSpace(schema)

0 commit comments

Comments
 (0)