Skip to content

Commit 02a936a

Browse files
Merge pull request #802 from wking/minimal-phony
Makefile: Remove unnecessary .PHONY entries
2 parents c4cc395 + 327a636 commit 02a936a

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

Makefile

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ DOC_FILES := \
3333

3434
default: docs
3535

36-
.PHONY: docs
3736
docs: $(OUTPUT_DIRNAME)/$(DOC_FILENAME).pdf $(OUTPUT_DIRNAME)/$(DOC_FILENAME).html
3837

3938
ifeq "$(strip $(PANDOC))" ''
@@ -56,8 +55,6 @@ HOST_GOLANG_VERSION = $(shell go version | cut -d ' ' -f3 | cut -c 3-)
5655
# this variable is used like a function. First arg is the minimum version, Second arg is the version to be checked.
5756
ALLOWED_GO_VERSION = $(shell test '$(shell /bin/echo -e "$(1)\n$(2)" | sort -V | head -n1)' = '$(1)' && echo 'true')
5857

59-
.PHONY: test .govet .golint .gitvalidation
60-
6158
test: .govet .golint .gitvalidation
6259

6360
.govet:
@@ -80,8 +77,6 @@ else
8077
git-validation -v -run DCO,short-subject,dangling-whitespace -range $(EPOCH_TEST_COMMIT)..HEAD
8178
endif
8279

83-
84-
.PHONY: install.tools
8580
install.tools: .install.golint .install.gitvalidation
8681

8782
# golint does not even build for <go1.6
@@ -93,8 +88,6 @@ endif
9388
.install.gitvalidation:
9489
go get -u github.com/vbatts/git-validation
9590

96-
97-
.PHONY: clean
9891
clean:
9992
rm -rf $(OUTPUT_DIRNAME) *~
10093
rm -f version.md

schema/Makefile

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,15 @@
11
GOOD_TESTS = $(wildcard test/good/*.json)
22
BAD_TESTS = $(wildcard test/bad/*.json)
33

4-
.PHONY: default
54
default: validate
65

7-
.PHONY: help
86
help:
97
@echo "Usage: make [target]"
108
@echo
119
@echo " * 'fmt' - format the json with indentation"
1210
@echo " * 'help' - show this help information"
1311
@echo " * 'validate' - build the validation tool"
1412

15-
.PHONY: fmt
1613
fmt:
1714
find . -name '*.json' -exec bash -c 'jq --indent 4 -M . {} > xx && mv xx {} || echo "skipping invalid {}"' \;
1815

@@ -21,7 +18,6 @@ validate: validate.go
2118
go get -d ./...
2219
go build ./validate.go
2320

24-
.PHONY: test
2521
test: validate $(TESTS)
2622
for TYPE in $$(ls test); \
2723
do \
@@ -50,6 +46,5 @@ test: validate $(TESTS)
5046
done; \
5147
done
5248

53-
.PHONY: clean
5449
clean:
5550
rm -f validate

0 commit comments

Comments
 (0)