Skip to content

Commit 09ec668

Browse files
committed
config-linux,schema: fix FileMode description
Originally, the file mode was indeed written in octal (see e.g. commit 5273b3d), but it was found out later that JSON does not allow octal values so the examples were changed to decimal in commit ccf3a24, but the "typically an octal value" bit (added by commit cdcabde) remains. Change it to emphasize the fact that this is in decimal. Also, add a note to config-linux.md saying the same thing. Signed-off-by: Kir Kolyshkin <[email protected]>
1 parent e83cdc2 commit 09ec668

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

config-linux.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ Each entry has the following structure:
135135
If a [file][] already exists at `path` that does not match the requested device, the runtime MUST generate an error.
136136
The path MAY be anywhere in the container filesystem, notably outside of `/dev`.
137137
* **`major, minor`** *(int64, REQUIRED unless `type` is `p`)* - [major, minor numbers][devices] for the device.
138-
* **`fileMode`** *(uint32, OPTIONAL)* - file mode for the device.
138+
* **`fileMode`** *(uint32, OPTIONAL)* - file mode for the device. Note it is a decimal (not an octal) number.
139139
You can also control access to devices [with cgroups](#configLinuxDeviceAllowedlist).
140140
* **`uid`** *(uint32, OPTIONAL)* - id of device owner in the [container namespace](glossary.md#container-namespace).
141141
* **`gid`** *(uint32, OPTIONAL)* - id of device group in the [container namespace](glossary.md#container-namespace).

schema/defs-linux.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@
149149
"$ref": "defs.json#/definitions/int64"
150150
},
151151
"FileMode": {
152-
"description": "File permissions mode (typically an octal value)",
152+
"description": "File permissions mode (in decimal, not octal)",
153153
"type": "integer",
154154
"minimum": 0,
155155
"maximum": 512

0 commit comments

Comments
 (0)