You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
runtime: Remove status redefinitions from operations
These states are already defined in the "State" section. There's no
need to redefine them in the operation sections.
Operation-level redefinitions are dicy anyway, because they imply
something testable about the immediately-after-this-operation time,
and it's not possible to run race-free tests of that time (e.g. the
process could die for other reasons between the successful 'create'
call and the 'state' call you made to look for a 'created' status).
Signed-off-by: W. Trevor King <[email protected]>
Copy file name to clipboardExpand all lines: runtime.md
-6Lines changed: 0 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -104,8 +104,6 @@ Using the data in [`config.json`](config.md), this operation MUST create a new c
104
104
This means that all of the resources associated with the container MUST be created, however, the user-specified program MUST NOT be run at this time.
105
105
If the runtime cannot create the container as specified in [`config.json`](config.md), it MUST [generate an error](#errors) and a new container MUST NOT be created.
106
106
107
-
Upon successful completion of this operation the `status` property of this container MUST be `created`.
108
-
109
107
The runtime MAY validate `config.json` against this spec, either generically or with respect to the local system capabilities, before creating the container ([step 2](#lifecycle)).
110
108
Runtime callers who are interested in pre-create validation can run [bundle-validation tools](implementations.md#testing--tools) before invoking the create operation.
111
109
@@ -119,17 +117,13 @@ Attempting to start a container that does not exist MUST [generate an error](#er
119
117
Attempting to start an already started container MUST have no effect on the container and MUST [generate an error](#errors).
120
118
This operation MUST run the user-specified program as specified by [`process`](config.md#process).
121
119
122
-
Upon successful completion of this operation the `status` property of this container MUST be `running`.
123
-
124
120
### <aname="runtimeKill" />Kill
125
121
`kill <container-id> <signal>`
126
122
127
123
This operation MUST [generate an error](#errors) if it is not provided the container ID.
128
124
Attempting to send a signal to a container that is not running MUST have no effect on the container and MUST [generate an error](#errors).
129
125
This operation MUST send the specified signal to the process in the container.
130
126
131
-
When the process in the container is stopped, irrespective of it being as a result of a `kill` operation or any other reason, the `status` property of this container MUST be `stopped`.
0 commit comments