Support for network namespace in windows

Dinesh Kumar Govindasamy · msabansal · Dinesh Kumar Govindasamy · commit 6f5fcd44f697 · 2018-08-31T13:57:28.000-07:00
This is to add network namespace support for Windows

Signed-off-by: Dinesh Govindasamy &lt;dingov@microsoft.com&gt;
Co-Authored-By: msabansal &lt;sabansal@microsoft.com&gt;
diff --git a/config-windows.md b/config-windows.md
@@ -125,6 +125,7 @@ The following parameters can be specified:
 * **`allowUnqualifiedDNSQuery`** *(bool, OPTIONAL)* - specifies if unqualified DNS name resolution is allowed.
 * **`DNSSearchList`** *(array of strings, OPTIONAL)* - comma separated list of DNS suffixes to use for name resolution.
 * **`networkSharedContainerName`** *(string, OPTIONAL)* - name (ID) of the container that we will share with the network stack.
+* **`networkNamespace`** *(string, OPTIONAL)* - name (ID) of the network namespace that will be used for the container. If a network namespace is specified no other parameter must be specified.
 
 ### Example
 
@@ -139,7 +140,8 @@ The following parameters can be specified:
                 "a.com",
                 "b.com"
             ],
-            "networkSharedContainerName": "containerName"
+            "networkSharedContainerName": "containerName",
+            "networkNamespace": "168f3daf-efc6-4377-b20a-2c86764ba892"
         }
    }
 ```
diff --git a/schema/config-windows.json b/schema/config-windows.json
@@ -71,6 +71,9 @@
                     },
                     "networkSharedContainerName": {
                         "type": "string"
+                    },
+                    "networkNamespace": {
+                        "type": "string"
                     }
                 }
             },
diff --git a/specs-go/config.go b/specs-go/config.go
@@ -503,6 +503,8 @@ type WindowsNetwork struct {
 	DNSSearchList []string `json:"DNSSearchList,omitempty"`
 	// Name (ID) of the container that we will share with the network stack.
 	NetworkSharedContainerName string `json:"networkSharedContainerName,omitempty"`
+	// name (ID) of the network namespace that will be used for the container.
+	NetworkNamespace string `json:"networkNamespace,omitempty"`
 }
 
 // WindowsHyperV contains information for configuring a container to run with Hyper-V isolation.

Original file line number	Diff line number	Diff line change
`@@ -71,6 +71,9 @@`
`71`	`71`	`},`
`72`	`72`	`"networkSharedContainerName": {`
`73`	`73`	`"type": "string"`
	`74`	`+ },`
	`75`	`+ "networkNamespace": {`
	`76`	`+ "type": "string"`
`74`	`77`	`}`
`75`	`78`	`}`
`76`	`79`	`},`
Original file line number	Diff line number	Diff line change
`@@ -503,6 +503,8 @@ type WindowsNetwork struct {`
`503`	`503`	DNSSearchList []string `json:"DNSSearchList,omitempty"`
`504`	`504`	`// Name (ID) of the container that we will share with the network stack.`
`505`	`505`	NetworkSharedContainerName string `json:"networkSharedContainerName,omitempty"`
	`506`	`+ // name (ID) of the network namespace that will be used for the container.`
	`507`	+ NetworkNamespace string `json:"networkNamespace,omitempty"`
`506`	`508`	`}`
`507`	`509`
`508`	`510`	`// WindowsHyperV contains information for configuring a container to run with Hyper-V isolation.`