Skip to content

Commit c871e4a

Browse files
committed
Clarify wording for terminal setting and /dev/console
Signed-off-by: Mrunal Patel <[email protected]>
1 parent 95a6ecf commit c871e4a

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

config-linux.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ In addition to any devices configured with this setting, the runtime MUST also s
147147
* [`/dev/random`][random.4]
148148
* [`/dev/urandom`][random.4]
149149
* [`/dev/tty`][tty.4]
150-
* [`/dev/console`][console.4]
150+
* [`/dev/console`][console.4] is setup if terminal is enabled in the config by bind mounting the psuedoterminal slave to /dev/console.
151151
* [`/dev/ptmx`][pts.4].
152152
A [bind-mount or symlink of the container's `/dev/pts/ptmx`][devpts].
153153

config.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,8 @@ See links for details about [mountvol](http://ss64.com/nt/mountvol.html) and [Se
9090

9191
## Process configuration
9292

93-
* **`terminal`** (bool, optional) specifies whether you want a terminal attached to that process, defaults to false.
93+
* **`terminal`** (bool, optional) specifies whether a terminal is attached to that process, defaults to false.
94+
On Linux, a psuedoterminal pair is allocated for the container process and the psuedoterminal slave is duplicated on the container process's [standard streams][stdin.3].
9495
* **`cwd`** (string, required) is the working directory that will be set for the executable.
9596
This value MUST be an absolute path.
9697
* **`env`** (array of strings, optional) contains a list of variables that will be set in the process's environment prior to execution.
@@ -691,3 +692,4 @@ Here is a full example `config.json` for reference.
691692
[mount.8-filesystem-independent]: http://man7.org/linux/man-pages/man8/mount.8.html#FILESYSTEM-INDEPENDENT_MOUNT OPTIONS
692693
[mount.8-filesystem-specific]: http://man7.org/linux/man-pages/man8/mount.8.html#FILESYSTEM-SPECIFIC_MOUNT OPTIONS
693694
[mount.8]: http://man7.org/linux/man-pages/man8/mount.8.html
695+
[stdin.3]: http://man7.org/linux/man-pages/man3/stdin.3.html

0 commit comments

Comments
 (0)