-
Notifications
You must be signed in to change notification settings - Fork 593
Description
It's backed by memory.oom_control (see the in-flight #745), so I expect it should go with the rest of the memory-controller config. I expect consistency in these groupings will be useful as we work through #746.
Looking at the history, the initial request landing a setting for this in the Docker/OCI ecosystem seems to be docker-archive/libcontainer#417, which added Cgroup.OomKillDisable. That commit was carried from libcontainer into runC (opencontainers/runc@295c7086) where it is now Resources.OomKillDisable. From runC it was carried into this repo (with some renaming) in #51. Subsequent early doc updates landed in #137 and #199. In none of those can I find discussion about why the setting is not already under memory. I expect the reason is that the runC structures are flat, so “under memory” is not a thing there. But in this spec, resources has per-controller sub-properties. The fact that disableOOMKiller belonged to the memory controller may have been overlooked in #51 and never revisited until this issue.
I'm happy to submit a PR if the move sounds appropriate.