-
Notifications
You must be signed in to change notification settings - Fork 593
Description
Issue:
The latest version tag of runtime-spec is v1.0.1, which is tagged about one year ago:
$ git tag -l | grep v1.0
v1.0.0
v1.0.0-rc1
v1.0.0-rc2
v1.0.0-rc3
v1.0.0-rc4
v1.0.0-rc5
v1.0.0-rc6
v1.0.1
$ git show v1.0.1
tag v1.0.1
Tagger: Vincent Batts <[email protected]>
Date: Tue Nov 7 18:24:55 2017 -0500
Version tag v1.0.1 is lack of dependencies of recent runc changes. For example:
opencontainers/runc#1632 depends on commit 5684b8a
opencontainers/runc#1919 depends on commit 1722abf
In runc verdor config file (https://github.com/opencontainers/runc/blob/master/vendor.conf), runc prefers to specify a version tag of runtime-spec rather than a commit ID. But now it is a commit ID because of the dependencies:
github.com/opencontainers/runtime-spec 5684b8af48c1ac3b1451fa499724e30e3c20a294
Proposal:
How about adding a new version tag (e.g., v1.0.2-rc1 or something) to a recent commit ID, which contains runtime-spec changes after v1.0.1 for runc dependencies? And then we could update runtime-spec version tag in runc vendor config file (https://github.com/opencontainers/runc/blob/master/vendor.conf) as:
github.com/opencontainers/runtime-spec v1.0.2-rc1
@crosbymichael @vishh @mrunalp @vbatts @dqminh @philips @tianon @hqhq
Hi runtime-spec maintainers,
Do you have any suggestions? Thank you!