Merge pull request #398 from q384566678/windows-check

liangchenye · web-flow · commit ca03d444ed8d · 2017-07-06T15:10:59.000+08:00
validate: increase the validation of windows fields
diff --git a/validate/validate.go b/validate/validate.go
@@ -424,7 +424,11 @@ func (v *Validator) CheckPlatform() (msgs []string) {
 		}
 	}
 
-	if v.platform != "windows" {
+	if v.platform == "windows" {
+		if v.spec.Windows == nil {
+			msgs = append(msgs, "'windows' MUST be set when platform is `windows`")
+		}
+	} else {
 		if v.spec.Windows != nil {
 			msgs = append(msgs, fmt.Sprintf("'windows' MUST NOT be set when target platform is %q", v.platform))
 		}

Original file line number	Diff line number	Diff line change
`@@ -424,7 +424,11 @@ func (v *Validator) CheckPlatform() (msgs []string) {`
`424`	`424`	`}`
`425`	`425`	`}`
`426`	`426`
`427`		`- if v.platform != "windows" {`
	`427`	`+ if v.platform == "windows" {`
	`428`	`+ if v.spec.Windows == nil {`
	`429`	+ msgs = append(msgs, "'windows' MUST be set when platform is `windows`")
	`430`	`+ }`
	`431`	`+ } else {`
`428`	`432`	`if v.spec.Windows != nil {`
`429`	`433`	`msgs = append(msgs, fmt.Sprintf("'windows' MUST NOT be set when target platform is %q", v.platform))`
`430`	`434`	`}`