implement add/set function for hooks items

Signed-off-by: Ma Shimiao <[email protected]>

Author: Ma Shimiao

cmd/oci-runtime-tool/generate.go

@@ -354,7 +354,7 @@ func setupSpec(g *generate.Generator, context *cli.Context) error {
 		for _, postStartEnv := range postStartEnvs {
 			path, env, err := parseHookEnv(postStartEnv)
 			if err != nil {
-				return nil
+				return err
 			}
 			g.AddPostStartHookEnv(path, env)
 		}
@@ -387,7 +387,7 @@ func setupSpec(g *generate.Generator, context *cli.Context) error {
 		for _, postStopEnv := range postStopEnvs {
 			path, env, err := parseHookEnv(postStopEnv)
 			if err != nil {
-				return nil
+				return err
 			}
 			g.AddPostStopHookEnv(path, env)
 		}
@@ -398,7 +398,7 @@ func setupSpec(g *generate.Generator, context *cli.Context) error {
 		for _, postStopTimeout := range postStopTimeouts {
 			path, timeout, err := parseHookTimeout(postStopTimeout)
 			if err != nil {
-				return nil
+				return err
 			}
 			g.AddPostStopHookTimeout(path, timeout)
 		}
@@ -409,7 +409,7 @@ func setupSpec(g *generate.Generator, context *cli.Context) error {
 		for _, hook := range preStartHooks {
 			path, args, err := parseHook(hook)
 			if err != nil {
-				return nil
+				return err
 			}
 			g.AddPreStartHook(path, args)
 		}
@@ -420,7 +420,7 @@ func setupSpec(g *generate.Generator, context *cli.Context) error {
 		for _, preStartEnv := range preStartEnvs {
 			path, env, err := parseHookEnv(preStartEnv)
 			if err != nil {
-				return nil
+				return err
 			}
 			g.AddPreStartHookEnv(path, env)
 		}
@@ -431,7 +431,7 @@ func setupSpec(g *generate.Generator, context *cli.Context) error {
 		for _, preStartTimeout := range preStartTimeouts {
 			path, timeout, err := parseHookTimeout(preStartTimeout)
 			if err != nil {
-				return nil
+				return err
 			}
 			g.AddPreStartHookTimeout(path, timeout)
 		}

generate/generate.go

@@ -744,29 +744,39 @@ func (g *Generator) ClearPreStartHooks() {
 func (g *Generator) AddPreStartHook(path string, args []string) {
 	g.initSpecHooks()
 	hook := rspec.Hook{Path: path, Args: args}
+	for i, hook := range g.spec.Hooks.Prestart {
+		if hook.Path == path {
+			g.spec.Hooks.Prestart[i] = hook
+			return
+		}
+	}
 	g.spec.Hooks.Prestart = append(g.spec.Hooks.Prestart, hook)
 }
 
 // AddPreStartHookEnv adds envs of a prestart hook into g.spec.Hooks.Prestart.
 func (g *Generator) AddPreStartHookEnv(path string, envs []string) {
-	g.initSpec()
+	g.initSpecHooks()
 	for i, hook := range g.spec.Hooks.Prestart {
 		if hook.Path == path {
 			g.spec.Hooks.Prestart[i].Env = envs
 			return
 		}
 	}
+	hook := rspec.Hook{Path: path, Env: envs}
+	g.spec.Hooks.Prestart = append(g.spec.Hooks.Prestart, hook)
 }
 
 // AddPreStartHookTimeout adds timeout of a prestart hook into g.spec.Hooks.Prestart.
 func (g *Generator) AddPreStartHookTimeout(path string, timeout int) {
-	g.initSpec()
+	g.initSpecHooks()
 	for i, hook := range g.spec.Hooks.Prestart {
 		if hook.Path == path {
 			g.spec.Hooks.Prestart[i].Timeout = &timeout
 			return
 		}
 	}
+	hook := rspec.Hook{Path: path, Timeout: &timeout}
+	g.spec.Hooks.Prestart = append(g.spec.Hooks.Prestart, hook)
 }
 
 // ClearPostStopHooks clear g.spec.Hooks.Poststop.
@@ -784,29 +794,39 @@ func (g *Generator) ClearPostStopHooks() {
 func (g *Generator) AddPostStopHook(path string, args []string) {
 	g.initSpecHooks()
 	hook := rspec.Hook{Path: path, Args: args}
+	for i, hook := range g.spec.Hooks.Poststop {
+		if hook.Path == path {
+			g.spec.Hooks.Poststop[i] = hook
+			return
+		}
+	}
 	g.spec.Hooks.Poststop = append(g.spec.Hooks.Poststop, hook)
 }
 
 // AddPostStopHookEnv adds envs of a poststop hook into g.spec.Hooks.Poststop.
 func (g *Generator) AddPostStopHookEnv(path string, envs []string) {
-	g.initSpec()
+	g.initSpecHooks()
 	for i, hook := range g.spec.Hooks.Poststop {
 		if hook.Path == path {
 			g.spec.Hooks.Poststop[i].Env = envs
 			return
 		}
 	}
+	hook := rspec.Hook{Path: path, Env: envs}
+	g.spec.Hooks.Poststop = append(g.spec.Hooks.Poststop, hook)
 }
 
 // AddPostStopHookTimeout adds timeout of a poststop hook into g.spec.Hooks.Poststop.
 func (g *Generator) AddPostStopHookTimeout(path string, timeout int) {
-	g.initSpec()
+	g.initSpecHooks()
 	for i, hook := range g.spec.Hooks.Poststop {
 		if hook.Path == path {
 			g.spec.Hooks.Poststop[i].Timeout = &timeout
 			return
 		}
 	}
+	hook := rspec.Hook{Path: path, Timeout: &timeout}
+	g.spec.Hooks.Poststop = append(g.spec.Hooks.Poststop, hook)
 }
 
 // ClearPostStartHooks clear g.spec.Hooks.Poststart.
@@ -824,29 +844,39 @@ func (g *Generator) ClearPostStartHooks() {
 func (g *Generator) AddPostStartHook(path string, args []string) {
 	g.initSpecHooks()
 	hook := rspec.Hook{Path: path, Args: args}
+	for i, hook := range g.spec.Hooks.Poststart {
+		if hook.Path == path {
+			g.spec.Hooks.Poststart[i] = hook
+			return
+		}
+	}
 	g.spec.Hooks.Poststart = append(g.spec.Hooks.Poststart, hook)
 }
 
 // AddPostStartHookEnv adds envs of a poststart hook into g.spec.Hooks.Poststart.
 func (g *Generator) AddPostStartHookEnv(path string, envs []string) {
-	g.initSpec()
+	g.initSpecHooks()
 	for i, hook := range g.spec.Hooks.Poststart {
 		if hook.Path == path {
 			g.spec.Hooks.Poststart[i].Env = envs
 			return
 		}
 	}
+	hook := rspec.Hook{Path: path, Env: envs}
+	g.spec.Hooks.Poststart = append(g.spec.Hooks.Poststart, hook)
 }
 
 // AddPostStartHookTimeout adds timeout of a poststart hook into g.spec.Hooks.Poststart.
 func (g *Generator) AddPostStartHookTimeout(path string, timeout int) {
-	g.initSpec()
+	g.initSpecHooks()
 	for i, hook := range g.spec.Hooks.Poststart {
 		if hook.Path == path {
 			g.spec.Hooks.Poststart[i].Timeout = &timeout
 			return
 		}
 	}
+	hook := rspec.Hook{Path: path, Timeout: &timeout}
+	g.spec.Hooks.Poststart = append(g.spec.Hooks.Poststart, hook)
 }
 
 // AddTmpfsMount adds a tmpfs mount into g.spec.Mounts.