validation: fix ST1017: don't use Yoda conditions

kolyshkin · kolyshkin · commit ee105294c044 · 2025-11-05T18:54:35.000-08:00
Or, in other words, un-Yoda-fy.

Signed-off-by: Kir Kolyshkin &lt;kolyshkin@gmail.com&gt;
diff --git a/validation/hostname/hostname.go b/validation/hostname/hostname.go
@@ -30,7 +30,7 @@ func main() {
 	t.Header(0)
 	defer t.AutoPlan()
 
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		t.Skip(1, "linux-specific namespace test")
 	}
 
diff --git a/validation/linux_cgroups_blkio/linux_cgroups_blkio.go b/validation/linux_cgroups_blkio/linux_cgroups_blkio.go
@@ -50,7 +50,7 @@ func testBlkioCgroups(rate uint64, isEmpty bool) error {
 }
 
 func main() {
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		util.Fatal(fmt.Errorf("linux-specific cgroup test"))
 	}
 
diff --git a/validation/linux_cgroups_cpus/linux_cgroups_cpus.go b/validation/linux_cgroups_cpus/linux_cgroups_cpus.go
@@ -119,7 +119,7 @@ func testEmptyCPU() error {
 }
 
 func main() {
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		util.Fatal(fmt.Errorf("linux-specific cgroup test"))
 	}
 
diff --git a/validation/linux_cgroups_hugetlb/linux_cgroups_hugetlb.go b/validation/linux_cgroups_hugetlb/linux_cgroups_hugetlb.go
@@ -88,7 +88,7 @@ func testWrongHugetlb() error {
 }
 
 func main() {
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		util.Fatal(fmt.Errorf("linux-specific cgroup test"))
 	}
 
diff --git a/validation/linux_cgroups_memory/linux_cgroups_memory.go b/validation/linux_cgroups_memory/linux_cgroups_memory.go
@@ -10,7 +10,7 @@ import (
 )
 
 func main() {
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		util.Fatal(fmt.Errorf("linux-specific cgroup test"))
 	}
 
diff --git a/validation/linux_cgroups_network/linux_cgroups_network.go b/validation/linux_cgroups_network/linux_cgroups_network.go
@@ -98,7 +98,7 @@ func testNetworkCgroups() error {
 }
 
 func main() {
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		util.Fatal(fmt.Errorf("linux-specific cgroup test"))
 	}
 
diff --git a/validation/linux_ns_itype/linux_ns_itype.go b/validation/linux_ns_itype/linux_ns_itype.go
@@ -118,7 +118,7 @@ func main() {
 	t := tap.New()
 	t.Header(0)
 
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		t.Skip(1, "linux-specific namespace test")
 	}
 
diff --git a/validation/linux_ns_nopath/linux_ns_nopath.go b/validation/linux_ns_nopath/linux_ns_nopath.go
@@ -119,7 +119,7 @@ func main() {
 	t := tap.New()
 	t.Header(0)
 
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		t.Skip(1, "linux-specific namespace test")
 	}
 
diff --git a/validation/linux_ns_path/linux_ns_path.go b/validation/linux_ns_path/linux_ns_path.go
@@ -148,7 +148,7 @@ func main() {
 	}
 
 	for _, c := range cases {
-		if "linux" != runtime.GOOS {
+		if runtime.GOOS != "linux" {
 			t.Skip(1, fmt.Sprintf("linux-specific namespace test: %s", c))
 		}
 
diff --git a/validation/linux_ns_path_type/linux_ns_path_type.go b/validation/linux_ns_path_type/linux_ns_path_type.go
@@ -93,7 +93,7 @@ func main() {
 	}
 
 	for _, c := range cases {
-		if "linux" != runtime.GOOS {
+		if runtime.GOOS != "linux" {
 			t.Skip(1, fmt.Sprintf("linux-specific namespace test: %s", c))
 		}
 
diff --git a/validation/process_capabilities/process_capabilities.go b/validation/process_capabilities/process_capabilities.go
@@ -8,7 +8,7 @@ import (
 )
 
 func main() {
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		util.Skip("linux-specific process.capabilities test", map[string]string{"OS": runtime.GOOS})
 		os.Exit(0)
 	}
diff --git a/validation/process_capabilities_fail/process_capabilities_fail.go b/validation/process_capabilities_fail/process_capabilities_fail.go
@@ -11,7 +11,7 @@ import (
 )
 
 func main() {
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		util.Skip("linux-specific process.capabilities test", map[string]string{"OS": runtime.GOOS})
 		os.Exit(0)
 	}
diff --git a/validation/process_rlimits/process_rlimits.go b/validation/process_rlimits/process_rlimits.go
@@ -8,7 +8,7 @@ import (
 )
 
 func main() {
-	if "linux" != runtime.GOOS && "solaris" != runtime.GOOS {
+	if runtime.GOOS != "linux" && runtime.GOOS != "solaris" {
 		util.Skip("POSIX-specific process.rlimits test", map[string]string{"OS": runtime.GOOS})
 		os.Exit(0)
 	}
diff --git a/validation/process_rlimits_fail/process_rlimits_fail.go b/validation/process_rlimits_fail/process_rlimits_fail.go
@@ -11,7 +11,7 @@ import (
 )
 
 func main() {
-	if "linux" != runtime.GOOS && "solaris" != runtime.GOOS {
+	if runtime.GOOS != "linux" && runtime.GOOS != "solaris" {
 		util.Skip("POSIX-specific process.rlimits test", map[string]string{"OS": runtime.GOOS})
 		os.Exit(0)
 	}
diff --git a/validation/root_readonly_true/root_readonly_true.go b/validation/root_readonly_true/root_readonly_true.go
@@ -8,7 +8,7 @@ import (
 )
 
 func main() {
-	if "windows" == runtime.GOOS {
+	if runtime.GOOS == "windows" {
 		util.Skip("non-Windows root.readonly test", map[string]string{"OS": runtime.GOOS})
 		os.Exit(0)
 	}

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ func main() {`
`30`	`30`	`t.Header(0)`
`31`	`31`	`defer t.AutoPlan()`
`32`	`32`
`33`		`- if "linux" != runtime.GOOS {`
	`33`	`+ if runtime.GOOS != "linux" {`
`34`	`34`	`t.Skip(1, "linux-specific namespace test")`
`35`	`35`	`}`
`36`	`36`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ func testBlkioCgroups(rate uint64, isEmpty bool) error {`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`func main() {`
`53`		`- if "linux" != runtime.GOOS {`
	`53`	`+ if runtime.GOOS != "linux" {`
`54`	`54`	`util.Fatal(fmt.Errorf("linux-specific cgroup test"))`
`55`	`55`	`}`
`56`	`56`
Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ func testEmptyCPU() error {`
`119`	`119`	`}`
`120`	`120`
`121`	`121`	`func main() {`
`122`		`- if "linux" != runtime.GOOS {`
	`122`	`+ if runtime.GOOS != "linux" {`
`123`	`123`	`util.Fatal(fmt.Errorf("linux-specific cgroup test"))`
`124`	`124`	`}`
`125`	`125`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ func testWrongHugetlb() error {`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`func main() {`
`91`		`- if "linux" != runtime.GOOS {`
	`91`	`+ if runtime.GOOS != "linux" {`
`92`	`92`	`util.Fatal(fmt.Errorf("linux-specific cgroup test"))`
`93`	`93`	`}`
`94`	`94`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ import (`
`10`	`10`	`)`
`11`	`11`
`12`	`12`	`func main() {`
`13`		`- if "linux" != runtime.GOOS {`
	`13`	`+ if runtime.GOOS != "linux" {`
`14`	`14`	`util.Fatal(fmt.Errorf("linux-specific cgroup test"))`
`15`	`15`	`}`
`16`	`16`
Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ func testNetworkCgroups() error {`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`func main() {`
`101`		`- if "linux" != runtime.GOOS {`
	`101`	`+ if runtime.GOOS != "linux" {`
`102`	`102`	`util.Fatal(fmt.Errorf("linux-specific cgroup test"))`
`103`	`103`	`}`
`104`	`104`
Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ func main() {`
`118`	`118`	`t := tap.New()`
`119`	`119`	`t.Header(0)`
`120`	`120`
`121`		`- if "linux" != runtime.GOOS {`
	`121`	`+ if runtime.GOOS != "linux" {`
`122`	`122`	`t.Skip(1, "linux-specific namespace test")`
`123`	`123`	`}`
`124`	`124`
Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ func main() {`
`119`	`119`	`t := tap.New()`
`120`	`120`	`t.Header(0)`
`121`	`121`
`122`		`- if "linux" != runtime.GOOS {`
	`122`	`+ if runtime.GOOS != "linux" {`
`123`	`123`	`t.Skip(1, "linux-specific namespace test")`
`124`	`124`	`}`
`125`	`125`
Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ func main() {`
`148`	`148`	`}`
`149`	`149`
`150`	`150`	`for _, c := range cases {`
`151`		`- if "linux" != runtime.GOOS {`
	`151`	`+ if runtime.GOOS != "linux" {`
`152`	`152`	`t.Skip(1, fmt.Sprintf("linux-specific namespace test: %s", c))`
`153`	`153`	`}`
`154`	`154`
Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ func main() {`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`for _, c := range cases {`
`96`		`- if "linux" != runtime.GOOS {`
	`96`	`+ if runtime.GOOS != "linux" {`
`97`	`97`	`t.Skip(1, fmt.Sprintf("linux-specific namespace test: %s", c))`
`98`	`98`	`}`
`99`	`99`