merge branch 'oci-validation'

Closes: cyphar/umoci#31
Signed-off-by: Aleksa Sarai <[email protected]>

Author: cyphar

Dockerfile

@@ -23,7 +23,16 @@ RUN zypper ar -f -p 10 -g obs://Virtualization:containers obs-vc && \
     zypper ar -f -p 10 -g obs://home:cyphar obs-cyphar && \
 	zypper --gpg-auto-import-keys -n ref && \
 	zypper -n up
-RUN zypper -n in 'go>=1.6' git make skopeo go-mtree bats jq
+RUN zypper -n in \
+		bats \
+		git \
+		'go>=1.6' \
+		go-mtree \
+		jq \
+		make \
+		oci-image-tools \
+		oci-runtime-tools \
+		skopeo
 
 ENV GOPATH /go
 ENV PATH $GOPATH/bin:$PATH

image/generator/runtime.go

@@ -107,9 +107,11 @@ func MutateRuntimeSpec(g rgen.Generator, rootfs string, image v1.Image) error {
 	g.SetLinuxResourcesMemorySwap(uint64(image.Config.MemorySwap))
 
 	for vol := range image.Config.Volumes {
-		// XXX: Is it fine to generate source=""?
-		g.AddBindMount("", vol, []string{"rw", "rbind"})
+		// XXX: This is _fine_ but might cause some issues in the future.
+		g.AddTmpfsMount(vol, []string{"rw"})
 	}
 
+	// TODO: Handle annotations (both manifest and config annotations).
+
 	return nil
 }