Cleaning up.

Author: agarny

src/file/file_p.h

@@ -45,7 +45,7 @@ class File::Impl: public Logger::Impl
     CombineArchivePtr mCombineArchive;
 
     explicit Impl(const std::string &pFileNameOrUrl, bool pRetrieveContents);
-    ~Impl();
+    ~Impl() override;
 
     void checkType(const FilePtr &pOwner, bool pResetType = false);
 

src/logger/issue_p.h

@@ -27,7 +27,6 @@ class Issue::Impl
     std::string mDescription;
 
     explicit Impl(Type pType, const std::string &pDescription);
-    ~Impl() = default;
 
     Type type() const;
     std::string typeAsString() const;

src/logger/logger_p.h

@@ -32,6 +32,8 @@ class Logger::Impl
     IssuePtrs mErrors;
     IssuePtrs mWarnings;
 
+    virtual ~Impl() = default;
+
     bool hasIssues() const;
     size_t issueCount() const;
     IssuePtrs issues() const;

src/sed/sedabstracttask.cpp

@@ -38,12 +38,12 @@ SedAbstractTask::SedAbstractTask(Impl *pPimpl)
 
 SedAbstractTask::Impl *SedAbstractTask::pimpl()
 {
-    return reinterpret_cast<Impl *>(SedBase::pimpl());
+    return static_cast<Impl *>(SedBase::pimpl());
 }
 
 const SedAbstractTask::Impl *SedAbstractTask::pimpl() const
 {
-    return reinterpret_cast<const Impl *>(SedBase::pimpl());
+    return static_cast<const Impl *>(SedBase::pimpl());
 }
 
 } // namespace libOpenCOR

src/sed/sedanalysis.cpp

@@ -52,7 +52,7 @@ SedAnalysis::Impl *SedAnalysis::pimpl()
 /*---GRY---
 const SedAnalysis::Impl *SedAnalysis::pimpl() const
 {
-    return reinterpret_cast<const Impl *>(SedSimulation::pimpl());
+    return static_cast<const Impl *>(SedSimulation::pimpl());
 }
 */
 

src/sed/sedbase_p.h

@@ -32,7 +32,6 @@ class SedBase::Impl: public Logger::Impl
     std::string mMetaId;
 
     explicit Impl(const std::string &pId = {});
-    virtual ~Impl() = default;
 
     std::string id() const;
     void setId(const std::string &pId);

src/sed/seddatadescription.cpp

@@ -35,14 +35,14 @@ SedDataDescription::~SedDataDescription()
 /*---GRY---
 SedDataDescription::Impl *SedDataDescription::pimpl()
 {
-    return reinterpret_cast<Impl *>(SedBase::pimpl());
+    return static_cast<Impl *>(SedBase::pimpl());
 }
 */
 
 /*---GRY---
 const SedDataDescription::Impl *SedDataDescription::pimpl() const
 {
-    return reinterpret_cast<const Impl *>(SedBase::pimpl());
+    return static_cast<const Impl *>(SedBase::pimpl());
 }
 */
 

src/sed/seddatagenerator.cpp

@@ -35,14 +35,14 @@ SedDataGenerator::~SedDataGenerator()
 /*---GRY---
 SedDataGenerator::Impl *SedDataGenerator::pimpl()
 {
-    return reinterpret_cast<Impl *>(SedBase::pimpl());
+    return static_cast<Impl *>(SedBase::pimpl());
 }
 */
 
 /*---GRY---
 const SedDataGenerator::Impl *SedDataGenerator::pimpl() const
 {
-    return reinterpret_cast<const Impl *>(SedBase::pimpl());
+    return static_cast<const Impl *>(SedBase::pimpl());
 }
 */
 

src/sed/seddocument.cpp

@@ -430,12 +430,12 @@ SedDocument::~SedDocument()
 
 SedDocument::Impl *SedDocument::pimpl()
 {
-    return reinterpret_cast<Impl *>(Logger::pimpl());
+    return static_cast<Impl *>(Logger::pimpl());
 }
 
 const SedDocument::Impl *SedDocument::pimpl() const
 {
-    return reinterpret_cast<const Impl *>(Logger::pimpl());
+    return static_cast<const Impl *>(Logger::pimpl());
 }
 
 SedDocumentPtr SedDocument::create(const FilePtr &pFile)

src/sed/sedinstance.cpp

@@ -127,12 +127,12 @@ SedInstance::~SedInstance()
 
 SedInstance::Impl *SedInstance::pimpl()
 {
-    return reinterpret_cast<Impl *>(Logger::pimpl());
+    return static_cast<Impl *>(Logger::pimpl());
 }
 
 const SedInstance::Impl *SedInstance::pimpl() const
 {
-    return reinterpret_cast<const Impl *>(Logger::pimpl());
+    return static_cast<const Impl *>(Logger::pimpl());
 }
 
 double SedInstance::run()