Skip to content

Commit 4d23281

Browse files
fengshunlifengshunli
committed
Feat: add zap log print
Signed-off-by: fengshunli <[email protected]>
1 parent d7db7c6 commit 4d23281

File tree

35 files changed

+243
-361
lines changed

35 files changed

+243
-361
lines changed

‎cli/cli/cli.go‎

Lines changed: 32 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ package cli
2525
import (
2626
"errors"
2727
"fmt"
28+
"go.uber.org/zap"
2829
"io"
2930
"os"
3031
"path"
@@ -41,7 +42,7 @@ import (
4142
tui "github.com/opencurve/curveadm/internal/tui/common"
4243
"github.com/opencurve/curveadm/internal/utils"
4344
cliutil "github.com/opencurve/curveadm/internal/utils"
44-
log "github.com/opencurve/curveadm/pkg/log/glg"
45+
"github.com/opencurve/curveadm/pkg/log/zaplog"
4546
"github.com/opencurve/curveadm/pkg/module"
4647
)
4748

@@ -131,15 +132,19 @@ func (curveadm *CurveAdm) init() error {
131132
configure.ReplaceGlobals(config)
132133

133134
// (3) Init logger
134-
now := time.Now().Format("2006-01-02_15-04-05")
135-
logpath := fmt.Sprintf("%s/curveadm-%s.log", curveadm.logDir, now)
136-
if err := log.Init(config.GetLogLevel(), logpath); err != nil {
137-
return errno.ERR_INIT_LOGGER_FAILED.E(err)
138-
} else {
139-
log.Info("Init logger success",
140-
log.Field("LogPath", logpath),
141-
log.Field("LogLevel", config.GetLogLevel()))
142-
}
135+
logpath := fmt.Sprintf("%s/curveadm.log", curveadm.logDir)
136+
// if err := log.Init(config.GetLogLevel(), logpath); err != nil {
137+
// return errno.ERR_INIT_LOGGER_FAILED.E(err)
138+
// } else {
139+
// log.Info("Init logger success",
140+
// log.Field("LogPath", logpath),
141+
// log.Field("LogLevel", config.GetLogLevel()))
142+
// }
143+
144+
zaplog.LOG = zaplog.Init(config, logpath)
145+
146+
zaplog.LOG.Info("Init logger success",
147+
zap.String("LogPath", logpath))
143148

144149
// (4) Init error code
145150
errno.Init(logpath)
@@ -148,17 +153,17 @@ func (curveadm *CurveAdm) init() error {
148153
dbpath := fmt.Sprintf("%s/curveadm.db", curveadm.dataDir)
149154
s, err := storage.NewStorage(dbpath)
150155
if err != nil {
151-
log.Error("Init SQLite database failed",
152-
log.Field("Error", err))
156+
zaplog.LOG.Error("Init SQLite database failed",
157+
zap.Any("Error", err))
153158
return errno.ERR_INIT_SQL_DATABASE_FAILED.E(err)
154159
}
155160

156161
// (6) Get hosts
157162
var hosts storage.Hosts
158163
hostses, err := s.GetHostses()
159164
if err != nil {
160-
log.Error("Get hosts failed",
161-
log.Field("Error", err))
165+
zaplog.LOG.Error("Get hosts failed",
166+
zap.Any("Error", err))
162167
return errno.ERR_GET_HOSTS_FAILED.E(err)
163168
} else if len(hostses) == 1 {
164169
hosts = hostses[0]
@@ -167,20 +172,20 @@ func (curveadm *CurveAdm) init() error {
167172
// (7) Get current cluster
168173
cluster, err := s.GetCurrentCluster()
169174
if err != nil {
170-
log.Error("Get current cluster failed",
171-
log.Field("Error", err))
175+
zaplog.LOG.Error("Get current cluster failed",
176+
zap.Any("Error", err))
172177
return errno.ERR_GET_CURRENT_CLUSTER_FAILED.E(err)
173178
} else {
174-
log.Info("Get current cluster success",
175-
log.Field("ClusterId", cluster.Id),
176-
log.Field("ClusterName", cluster.Name))
179+
zaplog.LOG.Info("Get current cluster success",
180+
zap.Int("ClusterId", cluster.Id),
181+
zap.String("ClusterName", cluster.Name))
177182
}
178183

179184
// (8) Get Disks
180185
var disks storage.Disks
181186
diskses, err := s.GetDisks()
182187
if err != nil {
183-
log.Error("Get disks failed", log.Field("Error", err))
188+
zaplog.LOG.Error("Get disks failed", zap.Any("Error", err))
184189
return errno.ERR_GET_DISKS_FAILED.E(err)
185190
} else if len(diskses) > 0 {
186191
disks = diskses[0]
@@ -189,7 +194,7 @@ func (curveadm *CurveAdm) init() error {
189194
// (9) Get Disk Records
190195
diskRecords, err := s.GetDisk(comm.DISK_FILTER_ALL)
191196
if err != nil {
192-
log.Error("Get disk records failed", log.Field("Error", err))
197+
zaplog.LOG.Error("Get disk records failed", zap.Any("Error", err))
193198
return errno.ERR_GET_DISK_RECORDS_FAILED.E(err)
194199
}
195200

@@ -507,8 +512,8 @@ func (curveadm *CurveAdm) PreAudit(now time.Time, args []string) int64 {
507512
id, err := curveadm.Storage().InsertAuditLog(
508513
now, cwd, command, comm.AUDIT_STATUS_ABORT)
509514
if err != nil {
510-
log.Error("Insert audit log failed",
511-
log.Field("Error", err))
515+
zaplog.LOG.Error("Insert audit log failed",
516+
zap.Any("Error", err))
512517
}
513518

514519
return id
@@ -521,8 +526,8 @@ func (curveadm *CurveAdm) PostAudit(id int64, ec error) {
521526

522527
auditLogs, err := curveadm.Storage().GetAuditLog(id)
523528
if err != nil {
524-
log.Error("Get audit log failed",
525-
log.Field("Error", err))
529+
zaplog.LOG.Error("Get audit log failed",
530+
zap.Any("Error", err))
526531
return
527532
} else if len(auditLogs) != 1 {
528533
return
@@ -544,7 +549,7 @@ func (curveadm *CurveAdm) PostAudit(id int64, ec error) {
544549

545550
err = curveadm.Storage().SetAuditLogStatus(id, status, errorCode)
546551
if err != nil {
547-
log.Error("Set audit log status failed",
548-
log.Field("Error", err))
552+
zaplog.LOG.Error("Set audit log status failed",
553+
zap.Any("Error", err))
549554
}
550555
}

‎cli/command/cluster/add.go‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,9 @@ import (
3131
"github.com/opencurve/curveadm/internal/errno"
3232
"github.com/opencurve/curveadm/internal/playbook"
3333
"github.com/opencurve/curveadm/internal/utils"
34-
log "github.com/opencurve/curveadm/pkg/log/glg"
34+
"github.com/opencurve/curveadm/pkg/log/zaplog"
3535
"github.com/spf13/cobra"
36+
"go.uber.org/zap"
3637
)
3738

3839
const (
@@ -139,9 +140,9 @@ func runAdd(curveadm *cli.CurveAdm, options addOptions) error {
139140
storage := curveadm.Storage()
140141
clusters, err := storage.GetClusters(name)
141142
if err != nil {
142-
log.Error("Get clusters failed",
143-
log.Field("cluster name", name),
144-
log.Field("error", err))
143+
zaplog.LOG.Error("Get clusters failed",
144+
zap.String("cluster name", name),
145+
zap.Any("error", err))
145146
return errno.ERR_GET_ALL_CLUSTERS_FAILED.E(err)
146147
} else if len(clusters) > 0 {
147148
return errno.ERR_CLUSTER_ALREADY_EXIST.

‎cli/command/cluster/checkout.go‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,9 @@ import (
2828
"github.com/opencurve/curveadm/cli/cli"
2929
"github.com/opencurve/curveadm/internal/errno"
3030
cliutil "github.com/opencurve/curveadm/internal/utils"
31-
log "github.com/opencurve/curveadm/pkg/log/glg"
31+
"github.com/opencurve/curveadm/pkg/log/zaplog"
3232
"github.com/spf13/cobra"
33+
"go.uber.org/zap"
3334
)
3435

3536
type checkoutOptions struct {
@@ -59,8 +60,8 @@ func runCheckout(curveadm *cli.CurveAdm, options checkoutOptions) error {
5960
storage := curveadm.Storage()
6061
clusters, err := storage.GetClusters(clusterName)
6162
if err != nil {
62-
log.Error("Get clusters failed",
63-
log.Field("error", err))
63+
zaplog.LOG.Error("Get clusters failed",
64+
zap.Any("error", err))
6465
return errno.ERR_GET_ALL_CLUSTERS_FAILED.E(err)
6566
} else if len(clusters) == 0 {
6667
return errno.ERR_CLUSTER_NOT_FOUND.

‎cli/command/cluster/export.go‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,13 @@ package cluster
2424

2525
import (
2626
"fmt"
27+
"github.com/opencurve/curveadm/pkg/log/zaplog"
28+
"go.uber.org/zap"
2729
"os"
2830

2931
"github.com/opencurve/curveadm/cli/cli"
3032
"github.com/opencurve/curveadm/internal/storage"
3133
"github.com/opencurve/curveadm/internal/utils"
32-
log "github.com/opencurve/curveadm/pkg/log/glg"
3334
"github.com/spf13/cobra"
3435
)
3536

@@ -129,12 +130,12 @@ func runExport(curveadm *cli.CurveAdm, options exportOptions) error {
129130
storage := curveadm.Storage()
130131
clusters, err := storage.GetClusters(name)
131132
if err != nil {
132-
log.Error("GetClusters", log.Field("error", err))
133+
zaplog.LOG.Error("GetClusters", zap.Any("error", err))
133134
return err
134135
} else if len(clusters) == 0 {
135136
return fmt.Errorf("cluster %s not exist", name)
136137
} else if services, err := storage.GetServices(clusters[0].Id); err != nil {
137-
log.Error("GetServices", log.Field("error", err))
138+
zaplog.LOG.Error("GetServices", zap.Any("error", err))
138139
return err
139140
} else if err = exportCluster(clusters[0], services, options.outfile); err != nil {
140141
return err

‎cli/command/cluster/import.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import (
3030
"strconv"
3131
"strings"
3232

33-
"github.com/opencurve/curveadm/pkg/log/zaplog"
3433
"github.com/opencurve/curveadm/cli/cli"
3534
"github.com/opencurve/curveadm/internal/storage"
3635
"github.com/opencurve/curveadm/internal/utils"
@@ -189,7 +188,6 @@ func runImport(curveadm *cli.CurveAdm, options importOptions) error {
189188
storage := curveadm.Storage()
190189
clusters, err := storage.GetClusters(name)
191190
if err != nil {
192-
zaplog.Error("GetClusters", zaplog.Field("error", err))
193191
return err
194192
} else if len(clusters) != 0 {
195193
return fmt.Errorf("cluster %s already exist", name)

‎cli/command/cluster/list.go‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,9 @@ import (
2929
"github.com/opencurve/curveadm/internal/errno"
3030
"github.com/opencurve/curveadm/internal/tui"
3131
cliutil "github.com/opencurve/curveadm/internal/utils"
32-
log "github.com/opencurve/curveadm/pkg/log/glg"
32+
"github.com/opencurve/curveadm/pkg/log/zaplog"
3333
"github.com/spf13/cobra"
34+
"go.uber.org/zap"
3435
)
3536

3637
type listOptions struct {
@@ -62,8 +63,8 @@ func runList(curveadm *cli.CurveAdm, options listOptions) error {
6263
storage := curveadm.Storage()
6364
clusters, err := storage.GetClusters("%")
6465
if err != nil {
65-
log.Error("Get clusters failed",
66-
log.Field("error", err))
66+
zaplog.LOG.Error("Get clusters failed",
67+
zap.Any("error", err))
6768
return errno.ERR_GET_ALL_CLUSTERS_FAILED.E(err)
6869
}
6970

‎cli/command/cluster/remove.go‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,9 @@ import (
3030
"github.com/opencurve/curveadm/internal/errno"
3131
tui "github.com/opencurve/curveadm/internal/tui/common"
3232
cliutil "github.com/opencurve/curveadm/internal/utils"
33-
log "github.com/opencurve/curveadm/pkg/log/glg"
33+
"github.com/opencurve/curveadm/pkg/log/zaplog"
3434
"github.com/spf13/cobra"
35+
"go.uber.org/zap"
3536
)
3637

3738
type removeOptions struct {
@@ -86,8 +87,8 @@ func runRemove(curveadm *cli.CurveAdm, options removeOptions) error {
8687
clusterName := options.clusterName
8788
clusters, err := storage.GetClusters(clusterName) // Get all clusters
8889
if err != nil {
89-
log.Error("Get cluster failed",
90-
log.Field("error", err))
90+
zaplog.LOG.Error("Get cluster failed",
91+
zap.Any("error", err))
9192
return errno.ERR_GET_ALL_CLUSTERS_FAILED.E(err)
9293
} else if len(clusters) == 0 {
9394
return errno.ERR_CLUSTER_NOT_FOUND.

‎cli/command/restart.go‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import (
3434
"github.com/spf13/cobra"
3535
)
3636

37-
3837
var (
3938
RESTART_PLAYBOOK_STEPS = []int{
4039
playbook.RESTART_SERVICE,

‎cli/command/stop.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ func runStop(curveadm *cli.CurveAdm, options stopOptions) error {
107107
}
108108

109109
// 3) confirm by user
110-
pass := tui.ConfirmYes(tui.PromptStopService(options.id, options.role, options.host));
110+
pass := tui.ConfirmYes(tui.PromptStopService(options.id, options.role, options.host))
111111
if !pass {
112112
curveadm.WriteOut(tui.PromptCancelOpetation("stop service"))
113113
return errno.ERR_CANCEL_OPERATION

‎internal/build/build.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
//go:build debug
12
// +build debug
23

34
package build

0 commit comments

Comments
 (0)