Skip to content

Commit 27bf9e2

Browse files
committed
Merge pull request #1169 from ioxp:sfmFixes
2 parents 9b5aa2a + 363097e commit 27bf9e2

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

modules/sfm/src/libmv_light/libmv/logging/logging.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,11 @@
2323

2424
#include <glog/logging.h>
2525

26+
27+
#if defined _MSC_VER && _MSC_VER < 1900
28+
# define snprintf _snprintf
29+
#endif
30+
2631
#define LG LOG(INFO)
2732
#define V0 LOG(INFO)
2833
#define V1 LOG(INFO)

modules/sfm/src/libmv_light/libmv/simple_pipeline/pipeline.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,6 @@
3030
#include "libmv/simple_pipeline/tracks.h"
3131
#include "libmv/simple_pipeline/camera_intrinsics.h"
3232

33-
#ifdef _MSC_VER
34-
# define snprintf _snprintf
35-
#endif
36-
3733
namespace libmv {
3834
namespace {
3935

modules/sfm/src/reconstruct.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,7 @@ namespace sfm
152152
else
153153
{
154154
// TODO: implement me
155+
CV_Error(Error::StsNotImplemented, "Affine reconstruction not yet implemented");
155156
}
156157

157158
}
@@ -180,6 +181,7 @@ namespace sfm
180181
else
181182
{
182183
// TODO: implement me
184+
CV_Error(Error::StsNotImplemented, "Affine reconstruction not yet implemented");
183185
}
184186

185187
}
@@ -223,6 +225,7 @@ namespace sfm
223225
else
224226
{
225227
// TODO: implement me
228+
CV_Error(Error::StsNotImplemented, "Affine reconstruction not yet implemented");
226229
}
227230

228231
}
@@ -239,7 +242,7 @@ namespace sfm
239242

240243
if ( is_projective )
241244
{
242-
reconstruct_(images, Rs, Ts, K, points3d, false);
245+
reconstruct_(images, Rs, Ts, K, points3d);
243246
}
244247

245248

@@ -248,6 +251,7 @@ namespace sfm
248251
else
249252
{
250253
// TODO: implement me
254+
CV_Error(Error::StsNotImplemented, "Affine reconstruction not yet implemented");
251255
}
252256

253257
}

0 commit comments

Comments
 (0)