Fix memory leak caused by incorrect use of smart pointer.

Author: cudawarped

modules/cudacodec/src/frame_queue.cpp

@@ -46,10 +46,32 @@
 #ifdef HAVE_NVCUVID
 
 RawPacket::RawPacket(const unsigned char* _data, const size_t _size, const bool _containsKeyFrame) : size(_size), containsKeyFrame(_containsKeyFrame) {
-    data = cv::makePtr<unsigned char*>(new unsigned char[size]);
-    memcpy(*data, _data, size);
+    data = new unsigned char[size];
+    memcpy(data, _data, size);
 };
 
+RawPacket::~RawPacket() {
+    if (data) delete[] data;
+}
+
+RawPacket::RawPacket(const RawPacket& other) : RawPacket(other.data, other.size, other.containsKeyFrame) {
+}
+
+RawPacket::RawPacket(RawPacket&& other) noexcept : data(std::exchange(other.data, nullptr)), size(std::exchange(other.size, 0)),
+    containsKeyFrame(std::exchange(other.containsKeyFrame, false))  {
+}
+
+RawPacket& RawPacket::operator=(const RawPacket& other) {
+    return *this = RawPacket(other);
+}
+
+RawPacket& RawPacket::operator=(RawPacket&& other) noexcept {
+    std::swap(data, other.data);
+    size = other.size;
+    containsKeyFrame = other.containsKeyFrame;
+    return *this;
+}
+
 cv::cudacodec::detail::FrameQueue::~FrameQueue() {
     if (isFrameInUse_)
         delete[] isFrameInUse_;

modules/cudacodec/src/frame_queue.hpp

@@ -50,11 +50,16 @@
 class RawPacket {
 public:
     RawPacket(const unsigned char* _data, const size_t _size = 0, const bool _containsKeyFrame = false);
-    unsigned char* Data() const { return *data; }
-    size_t size;
-    bool containsKeyFrame;
+    ~RawPacket();
+    RawPacket(const RawPacket& other);
+    RawPacket(RawPacket&& other) noexcept;
+    RawPacket& operator=(const RawPacket& other);
+    RawPacket& operator=(RawPacket&& other) noexcept;
+    unsigned char* Data() const { return data; }
+    size_t size = 0;
+    bool containsKeyFrame = false;
 private:
-    cv::Ptr<unsigned char*> data = 0;
+    unsigned char* data = 0;
 };
 
 namespace cv { namespace cudacodec { namespace detail {