Merge pull request #1621 from alalek:replace_cv_errornoreturn

alalek · alalek · commit d6bbcd685dad · 2018-04-24T15:03:53.000Z
diff --git a/modules/datasets/src/or_pascal.cpp b/modules/datasets/src/or_pascal.cpp
@@ -143,7 +143,6 @@ Ptr<Object> OR_pascalImp::parseAnnotation(const string &path, const string &id)
         case XML_ERROR_FILE_NOT_FOUND:
             error_message = "XML file not found! " + error_message;
             CV_Error(Error::StsParseError, error_message);
-            return annotation;
         default:
             CV_Error(Error::StsParseError, error_message);
             break;
diff --git a/modules/face/src/face_alignment.cpp b/modules/face/src/face_alignment.cpp
@@ -79,8 +79,7 @@ bool FacemarkKazemiImpl::convertToUnit(Rect r,Mat &warp){
 bool FacemarkKazemiImpl::setMeanExtreme(){
     if(meanshape.empty()){
         String error_message = "Model not loaded properly.No mean shape found.Aborting...";
-        CV_ErrorNoReturn(Error::StsBadArg, error_message);
-        return false;
+        CV_Error(Error::StsBadArg, error_message);
     }
     for(size_t i=0;i<meanshape.size();i++){
         if(meanshape[i].x>maxmeanx)
@@ -98,7 +97,7 @@ bool FacemarkKazemiImpl::calcMeanShape (vector< vector<Point2f> >& trainlandmark
     //clear the loaded meanshape
     if(trainimages.empty()||trainlandmarks.size()!=trainimages.size()) {
         // throw error if no data (or simply return -1?)
-        CV_ErrorNoReturn(Error::StsBadArg, "Number of images is not equal to corresponding landmarks. Aborting...");
+        CV_Error(Error::StsBadArg, "Number of images is not equal to corresponding landmarks. Aborting...");
     }
     meanshape.clear();
     vector<Mat> finalimages;
@@ -165,7 +164,7 @@ bool FacemarkKazemiImpl::scaleData( vector< vector<Point2f> > & trainlandmarks,
 {
     if(trainimages.empty()||trainimages.size()!=trainlandmarks.size()){
         // throw error if no data (or simply return -1?)
-        CV_ErrorNoReturn(Error::StsBadArg, "The data is not loaded properly by train function. Aborting...");
+        CV_Error(Error::StsBadArg, "The data is not loaded properly by train function. Aborting...");
     }
     float scalex,scaley;
     //scale all images and their landmarks according  to input size
diff --git a/modules/face/src/facemark.cpp b/modules/face/src/facemark.cpp
@@ -228,8 +228,7 @@ bool loadTrainingData(vector<String> filename,vector< vector<Point2f> >
         f1.open(filename[j].c_str(),ios::in);
         if(!f1.is_open()){
             cout<<filename[j]<<endl;
-            CV_ErrorNoReturn(Error::StsError, "File can't be opened for reading!");
-            return false;
+            CV_Error(Error::StsError, "File can't be opened for reading!");
         }
         //get the path of the image whose landmarks have to be detected
         getline(f1,img);
diff --git a/modules/face/src/lbph_faces.cpp b/modules/face/src/lbph_faces.cpp
@@ -307,10 +307,8 @@ static Mat histc(InputArray _src, int minVal, int maxVal, bool normed)
         case CV_32FC1:
             return histc_(src, minVal, maxVal, normed);
             break;
-        default:
-            CV_Error(Error::StsUnmatchedFormats, "This type is not implemented yet."); break;
     }
-    return Mat();
+    CV_Error(Error::StsUnmatchedFormats, "This type is not implemented yet.");
 }
 
 
diff --git a/modules/face/src/regtree.cpp b/modules/face/src/regtree.cpp
@@ -113,8 +113,7 @@ bool FacemarkKazemiImpl:: getBestSplit(vector<Point2f> pixel_coordinates, vector
 {
     if(samples[0].shapeResiduals.size()!=samples[0].current_shape.size()){
         String error_message = "Error while generating split.Residuals are not complete.Aborting....";
-        CV_ErrorNoReturn(Error::StsBadArg, error_message);
-        return false;
+        CV_Error(Error::StsBadArg, error_message);
     }
     //This vector stores the matrices where each matrix represents
     //sum of the residuals of shapes of samples which go to the left
@@ -222,13 +221,11 @@ bool FacemarkKazemiImpl :: generateSplit(queue<node_info>& curr,vector<Point2f>
 bool FacemarkKazemiImpl :: buildRegtree(regtree& tree,vector<training_sample>& samples,vector<Point2f> pixel_coordinates){
     if(samples.size()==0){
         String error_message = "Error while building regression tree.Empty samples. Aborting....";
-        CV_ErrorNoReturn(Error::StsBadArg, error_message);
-        return false;
+        CV_Error(Error::StsBadArg, error_message);
     }
     if(pixel_coordinates.size()==0){
         String error_message = "Error while building regression tree.No pixel coordinates. Aborting....";
-        CV_ErrorNoReturn(Error::StsBadArg, error_message);
-        return false;
+        CV_Error(Error::StsBadArg, error_message);
     }
     queue<node_info> curr;
     node_info parent;
@@ -291,8 +288,7 @@ unsigned long FacemarkKazemiImpl::divideSamples (splitr split,vector<training_sa
 {
     if(samples.size()==0){
         String error_message = "Error while dividing samples. Sample array empty. Aborting....";
-        CV_ErrorNoReturn(Error::StsBadArg, error_message);
-        return 0;
+        CV_Error(Error::StsBadArg, error_message);
     }
     unsigned long i = start;
     training_sample temp;
diff --git a/modules/face/src/trainFacemark.cpp b/modules/face/src/trainFacemark.cpp
@@ -54,8 +54,7 @@ bool FacemarkKazemiImpl::setTrainingParameters(String filename){
     fs.open(filename, FileStorage::READ);
     if (!fs.isOpened())
     {   String error_message = "Error while opening configuration file.Aborting..";
-        CV_ErrorNoReturn(Error::StsBadArg, error_message);
-        return false;
+        CV_Error(Error::StsBadArg, error_message);
     }
     int cascade_depth_;
     int tree_depth_;
@@ -105,8 +104,7 @@ unsigned long FacemarkKazemiImpl::  getNearestLandmark(Point2f pixel)
     if(meanshape.empty()) {
             // throw error if no data (or simply return -1?)
             String error_message = "The data is not loaded properly by train function. Aborting...";
-            CV_ErrorNoReturn(Error::StsBadArg, error_message);
-            return false;
+            CV_Error(Error::StsBadArg, error_message);
     }
     float dist=float(INT_MAX);
     unsigned long index =0;
@@ -122,8 +120,7 @@ unsigned long FacemarkKazemiImpl::  getNearestLandmark(Point2f pixel)
 bool FacemarkKazemiImpl :: getRelativePixels(vector<Point2f> sample,vector<Point2f>& pixel_coordinates,std::vector<int> nearest){
     if(sample.size()!=meanshape.size()){
         String error_message = "Error while finding relative shape. Aborting....";
-        CV_ErrorNoReturn(Error::StsBadArg, error_message);
-        return false;
+        CV_Error(Error::StsBadArg, error_message);
     }
     Mat transform_mat;
     transform_mat = estimateRigidTransform(meanshape,sample,false);
@@ -146,8 +143,7 @@ bool FacemarkKazemiImpl :: getRelativePixels(vector<Point2f> sample,vector<Point
 bool FacemarkKazemiImpl::getPixelIntensities(Mat img,vector<Point2f> pixel_coordinates,vector<int>& pixel_intensities,Rect face){
     if(pixel_coordinates.size()==0){
         String error_message = "No pixel coordinates found. Aborting.....";
-        CV_ErrorNoReturn(Error::StsBadArg, error_message);
-        return false;
+        CV_Error(Error::StsBadArg, error_message);
     }
     Mat transform_mat;
     convertToActual(face,transform_mat);
@@ -259,13 +255,11 @@ bool FacemarkKazemiImpl :: saveModel(String filename){
     ofstream f(filename.c_str(),ios::binary);
     if(!f.is_open()){
         String error_message = "Error while opening file to write model. Aborting....";
-        CV_ErrorNoReturn(Error::StsBadArg, error_message);
-        return false;
+        CV_Error(Error::StsBadArg, error_message);
     }
     if(loaded_forests.size()!=loaded_pixel_coordinates.size()){
         String error_message = "Incorrect training data. Aborting....";
-        CV_ErrorNoReturn(Error::StsBadArg, error_message);
-        return false;
+        CV_Error(Error::StsBadArg, error_message);
     }
     string s("cascade_depth");
     uint64_t len = s.size();
@@ -306,23 +300,20 @@ void FacemarkKazemiImpl::training(String imageList, String groundTruth){
     imageList.clear();
     groundTruth.clear();
     String error_message = "Less arguments than required";
-    CV_ErrorNoReturn(Error::StsBadArg, error_message);
-    return ;
+    CV_Error(Error::StsBadArg, error_message);
 }
 bool FacemarkKazemiImpl::training(vector<Mat>& images, vector< vector<Point2f> >& landmarks,string filename,Size scale,string modelFilename){
     if(!setTrainingParameters(filename)){
         String error_message = "Error while loading training parameters";
-        CV_ErrorNoReturn(Error::StsBadArg, error_message);
-        return false;
+        CV_Error(Error::StsBadArg, error_message);
     }
     vector<Rect> rectangles;
     scaleData(landmarks,images,scale);
     calcMeanShape(landmarks,images,rectangles);
     if(images.size()!=landmarks.size()){
         // throw error if no data (or simply return -1?)
         String error_message = "The data is not loaded properly. Aborting training function....";
-        CV_ErrorNoReturn(Error::StsBadArg, error_message);
-        return false;
+        CV_Error(Error::StsBadArg, error_message);
     }
     vector<training_sample> samples;
     getTestCoordinates();
diff --git a/modules/line_descriptor/src/binary_descriptor.cpp b/modules/line_descriptor/src/binary_descriptor.cpp
@@ -337,13 +337,8 @@ int BinaryDescriptor::descriptorSize() const
 /* power function with error management */
 static inline int get2Pow( int i )
 {
-  if( i >= 0 && i <= 7 )
-    return 1 << i;
-  else
-  {
-    CV_Error( Error::StsBadArg, "Invalid power argument" );
-    return -1;
-  }
+  CV_DbgAssert(i >= 0 && i <= 7);
+  return 1 << i;
 }
 
 /* compute Gaussian pyramids */
diff --git a/modules/rgbd/src/linemod.cpp b/modules/rgbd/src/linemod.cpp
@@ -66,7 +66,6 @@ static inline int getLabel(int quantized)
     case 128: return 7;
     default:
       CV_Error(Error::StsBadArg, "Invalid value of quantized parameter");
-      return -1; //avoid warning
   }
 }
 
diff --git a/modules/tracking/src/gtrTracker.cpp b/modules/tracking/src/gtrTracker.cpp
@@ -58,7 +58,7 @@ Ptr<TrackerGOTURN> TrackerGOTURN::create(const TrackerGOTURN::Params &parameters
     return Ptr<gtr::TrackerGOTURNImpl>(new gtr::TrackerGOTURNImpl(parameters));
 #else
     (void)(parameters);
-    CV_ErrorNoReturn(cv::Error::StsNotImplemented , "to use GOTURN, the tracking module needs to be built with opencv_dnn !");
+    CV_Error(cv::Error::StsNotImplemented , "to use GOTURN, the tracking module needs to be built with opencv_dnn !");
 #endif
 }
 Ptr<TrackerGOTURN> TrackerGOTURN::create()
diff --git a/modules/tracking/src/tracker.cpp b/modules/tracking/src/tracker.cpp
@@ -73,7 +73,6 @@ bool Tracker::init( InputArray image, const Rect2d& boundingBox )
   if( model == 0 )
   {
     CV_Error( -1, "The model is not initialized" );
-    return false;
   }
 
   if( initTracker )
diff --git a/modules/tracking/src/trackerBoostingModel.cpp b/modules/tracking/src/trackerBoostingModel.cpp
@@ -89,7 +89,6 @@ void TrackerBoostingModel::responseToConfidenceMap( const std::vector<Mat>& resp
   if( currentSample.empty() )
   {
     CV_Error( -1, "The samples in Model estimation are empty" );
-    return;
   }
 
   for ( size_t i = 0; i < currentSample.size(); i++ )
diff --git a/modules/tracking/src/trackerFeature.cpp b/modules/tracking/src/trackerFeature.cpp
@@ -90,7 +90,6 @@ Ptr<TrackerFeature> TrackerFeature::create( const String& trackerFeatureType )
   }
 
   CV_Error( -1, "Tracker feature type not supported" );
-  return Ptr<TrackerFeature>();
 }
 
 String TrackerFeature::getClassName() const
diff --git a/modules/tracking/src/trackerMILModel.cpp b/modules/tracking/src/trackerMILModel.cpp
@@ -67,7 +67,6 @@ void TrackerMILModel::responseToConfidenceMap( const std::vector<Mat>& responses
   if( currentSample.empty() )
   {
     CV_Error( -1, "The samples in Model estimation are empty" );
-    return;
   }
 
   for ( size_t i = 0; i < responses.size(); i++ )
diff --git a/modules/tracking/src/trackerModel.cpp b/modules/tracking/src/trackerModel.cpp
@@ -112,7 +112,6 @@ bool TrackerModel::runStateEstimator()
   if( stateEstimator == 0 )
   {
     CV_Error( -1, "Tracker state estimator is not setted" );
-    return false;
   }
   Ptr<TrackerTargetState> targetState = stateEstimator->estimate( confidenceMaps );
   if( targetState == 0 )
diff --git a/modules/tracking/src/trackerSamplerAlgorithm.cpp b/modules/tracking/src/trackerSamplerAlgorithm.cpp
@@ -83,7 +83,6 @@ Ptr<TrackerSamplerAlgorithm> TrackerSamplerAlgorithm::create( const String& trac
   }
 
   CV_Error( -1, "Tracker sampler algorithm type not supported" );
-  return Ptr<TrackerSamplerAlgorithm>();
 }
 
 String TrackerSamplerAlgorithm::getClassName() const
diff --git a/modules/tracking/src/trackerStateEstimator.cpp b/modules/tracking/src/trackerStateEstimator.cpp
@@ -85,7 +85,6 @@ Ptr<TrackerStateEstimator> TrackerStateEstimator::create( const String& trackeSt
   }
 
   CV_Error( -1, "Tracker state estimator type not supported" );
-  return Ptr<TrackerStateEstimator>();
 }
 
 String TrackerStateEstimator::getClassName() const
diff --git a/modules/xfeatures2d/samples/bagofwords_classification.cpp b/modules/xfeatures2d/samples/bagofwords_classification.cpp
@@ -1794,12 +1794,9 @@ bool VocData::getClassifierGroundTruthImage(const string& obj_class, const strin
     {
         //image found, so return corresponding ground truth
         return m_classifier_gt_all_present[std::distance(m_classifier_gt_all_ids.begin(),it)] != 0;
-    } else {
-        string err_msg = "could not find classifier ground truth for image '" + id + "' and class '" + obj_class + "'";
-        CV_Error(Error::StsError,err_msg.c_str());
     }
-
-    return true;
+    string err_msg = "could not find classifier ground truth for image '" + id + "' and class '" + obj_class + "'";
+    CV_Error(Error::StsError,err_msg.c_str());
 }
 
 //-------------------------------------------------------------------
diff --git a/modules/xfeatures2d/src/pct_signatures/distance.hpp b/modules/xfeatures2d/src/pct_signatures/distance.hpp
@@ -204,10 +204,8 @@ namespace cv
                     return distanceL5(points1, idx1, points2, idx2);
                 case PCTSignatures::L_INFINITY:
                     return distanceLInfinity(points1, idx1, points2, idx2);
-                default:
-                    CV_Error(Error::StsBadArg, "Distance function not implemented!");
-                    return -1;
                 }
+                CV_Error(Error::StsBadArg, "Distance function not implemented!");
             }
         }
     }
diff --git a/modules/xfeatures2d/src/pct_signatures/similarity.hpp b/modules/xfeatures2d/src/pct_signatures/similarity.hpp
@@ -117,10 +117,8 @@ namespace cv
                     return gaussianSimilarity(distancefunction, similarityParameter, points1, idx1, points2, idx2);
                 case PCTSignatures::HEURISTIC:
                     return heuristicSimilarity(distancefunction, similarityParameter, points1, idx1, points2, idx2);
-                default:
-                    CV_Error(Error::StsNotImplemented, "Similarity function not implemented!");
-                    return -1;
                 }
+                CV_Error(Error::StsNotImplemented, "Similarity function not implemented!");
             }
         }
     }
diff --git a/modules/xfeatures2d/src/surf.cuda.cpp b/modules/xfeatures2d/src/surf.cuda.cpp
@@ -51,7 +51,7 @@ using namespace cv::cuda;
 
 cv::cuda::SURF_CUDA::SURF_CUDA() { throw_no_cuda(); }
 cv::cuda::SURF_CUDA::SURF_CUDA(double, int, int, bool, float, bool) { throw_no_cuda(); }
-int cv::cuda::SURF_CUDA::descriptorSize() const { throw_no_cuda(); return 0;}
+int cv::cuda::SURF_CUDA::descriptorSize() const { throw_no_cuda(); }
 void cv::cuda::SURF_CUDA::uploadKeypoints(const std::vector<KeyPoint>&, GpuMat&) { throw_no_cuda(); }
 void cv::cuda::SURF_CUDA::downloadKeypoints(const GpuMat&, std::vector<KeyPoint>&) { throw_no_cuda(); }
 void cv::cuda::SURF_CUDA::downloadDescriptors(const GpuMat&, std::vector<float>&) { throw_no_cuda(); }
diff --git a/modules/ximgproc/src/disparity_filters.cpp b/modules/ximgproc/src/disparity_filters.cpp
@@ -480,7 +480,6 @@ Ptr<StereoMatcher> createRightMatcher(Ptr<StereoMatcher> matcher_left)
     else
     {
         CV_Error(Error::StsBadArg, "createRightMatcher supports only StereoBM and StereoSGBM");
-        return Ptr<StereoMatcher>();
     }
 }
 
diff --git a/modules/ximgproc/src/weighted_median_filter.cpp b/modules/ximgproc/src/weighted_median_filter.cpp
@@ -56,6 +56,7 @@ void from32FTo32S(Mat &img, Mat &outImg, int nI, float *mapping)
 {
     int rows = img.rows, cols = img.cols;
     size_t alls = (size_t)rows * cols;
+    CV_Assert(alls < INT_MAX);
 
     CV_Assert(img.isContinuous());
     float *imgPtr = img.ptr<float>();
@@ -66,7 +67,7 @@ void from32FTo32S(Mat &img, Mat &outImg, int nI, float *mapping)
     for (size_t i = 0; i < alls; i++)
     {
         pairFI& d = data[i];
-        d.second = i;
+        d.second = (int)i;
         d.first = imgPtr[i];
     }
 
@@ -128,7 +129,7 @@ void from32FTo32S(Mat &img, Mat &outImg, int nI, float *mapping)
             mapping[cnt] = data[(baseI+i-1)>>1].first; //median
             cnt++;
             base = data[i].first;
-            baseI = i;
+            baseI = (int)i;
         }
         retImgPtr[data[i].second] = cnt;
     }

Original file line number	Diff line number	Diff line change
`@@ -307,10 +307,8 @@ static Mat histc(InputArray _src, int minVal, int maxVal, bool normed)`
`307`	`307`	`case CV_32FC1:`
`308`	`308`	`return histc_(src, minVal, maxVal, normed);`
`309`	`309`	`break;`
`310`		`- default:`
`311`		`- CV_Error(Error::StsUnmatchedFormats, "This type is not implemented yet."); break;`
`312`	`310`	`}`
`313`		`- return Mat();`
	`311`	`+ CV_Error(Error::StsUnmatchedFormats, "This type is not implemented yet.");`
`314`	`312`	`}`
`315`	`313`
`316`	`314`
Original file line number	Diff line number	Diff line change
`@@ -113,8 +113,7 @@ bool FacemarkKazemiImpl:: getBestSplit(vector<Point2f> pixel_coordinates, vector`
`113`	`113`	`{`
`114`	`114`	`if(samples[0].shapeResiduals.size()!=samples[0].current_shape.size()){`
`115`	`115`	`String error_message = "Error while generating split.Residuals are not complete.Aborting....";`
`116`		`- CV_ErrorNoReturn(Error::StsBadArg, error_message);`
`117`		`- return false;`
	`116`	`+ CV_Error(Error::StsBadArg, error_message);`
`118`	`117`	`}`
`119`	`118`	`//This vector stores the matrices where each matrix represents`
`120`	`119`	`//sum of the residuals of shapes of samples which go to the left`
`@@ -222,13 +221,11 @@ bool FacemarkKazemiImpl :: generateSplit(queue<node_info>& curr,vector<Point2f>`
`222`	`221`	`bool FacemarkKazemiImpl :: buildRegtree(regtree& tree,vector<training_sample>& samples,vector<Point2f> pixel_coordinates){`
`223`	`222`	`if(samples.size()==0){`
`224`	`223`	`String error_message = "Error while building regression tree.Empty samples. Aborting....";`
`225`		`- CV_ErrorNoReturn(Error::StsBadArg, error_message);`
`226`		`- return false;`
	`224`	`+ CV_Error(Error::StsBadArg, error_message);`
`227`	`225`	`}`
`228`	`226`	`if(pixel_coordinates.size()==0){`
`229`	`227`	`String error_message = "Error while building regression tree.No pixel coordinates. Aborting....";`
`230`		`- CV_ErrorNoReturn(Error::StsBadArg, error_message);`
`231`		`- return false;`
	`228`	`+ CV_Error(Error::StsBadArg, error_message);`
`232`	`229`	`}`
`233`	`230`	`queue<node_info> curr;`
`234`	`231`	`node_info parent;`
`@@ -291,8 +288,7 @@ unsigned long FacemarkKazemiImpl::divideSamples (splitr split,vector<training_sa`
`291`	`288`	`{`
`292`	`289`	`if(samples.size()==0){`
`293`	`290`	`String error_message = "Error while dividing samples. Sample array empty. Aborting....";`
`294`		`- CV_ErrorNoReturn(Error::StsBadArg, error_message);`
`295`		`- return 0;`
	`291`	`+ CV_Error(Error::StsBadArg, error_message);`
`296`	`292`	`}`
`297`	`293`	`unsigned long i = start;`
`298`	`294`	`training_sample temp;`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,6 @@ static inline int getLabel(int quantized)`
`66`	`66`	`case 128: return 7;`
`67`	`67`	`default:`
`68`	`68`	`CV_Error(Error::StsBadArg, "Invalid value of quantized parameter");`
`69`		`- return -1; //avoid warning`
`70`	`69`	`}`
`71`	`70`	`}`
`72`	`71`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ Ptr<TrackerGOTURN> TrackerGOTURN::create(const TrackerGOTURN::Params &parameters`
`58`	`58`	`return Ptr<gtr::TrackerGOTURNImpl>(new gtr::TrackerGOTURNImpl(parameters));`
`59`	`59`	`#else`
`60`	`60`	`(void)(parameters);`
`61`		`- CV_ErrorNoReturn(cv::Error::StsNotImplemented , "to use GOTURN, the tracking module needs to be built with opencv_dnn !");`
	`61`	`+ CV_Error(cv::Error::StsNotImplemented , "to use GOTURN, the tracking module needs to be built with opencv_dnn !");`
`62`	`62`	`#endif`
`63`	`63`	`}`
`64`	`64`	`Ptr<TrackerGOTURN> TrackerGOTURN::create()`
Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,6 @@ bool Tracker::init( InputArray image, const Rect2d& boundingBox )`
`73`	`73`	`if( model == 0 )`
`74`	`74`	`{`
`75`	`75`	`CV_Error( -1, "The model is not initialized" );`
`76`		`- return false;`
`77`	`76`	`}`
`78`	`77`
`79`	`78`	`if( initTracker )`