Skip to content

Commit 237f55f

Browse files
Merge pull request #184 from hbelmiro/dsp-fix-warnings-dockerfiles
UPSTREAM<carry>: Fixed warnings in Dockerfiles
2 parents 8e935aa + 3d10ab9 commit 237f55f

File tree

5 files changed

+14
-14
lines changed

5 files changed

+14
-14
lines changed

backend/Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# Build arguments
1616
ARG SOURCE_CODE=.
1717

18-
FROM registry.access.redhat.com/ubi9/go-toolset:1.23 as builder
18+
FROM registry.access.redhat.com/ubi9/go-toolset:1.23 AS builder
1919

2020
USER root
2121

@@ -35,15 +35,15 @@ RUN GO111MODULE=on CGO_ENABLED=1 GOEXPERIMENT=strictfipsruntime go build -tags s
3535
dnf clean all
3636

3737
# 2. Compile preloaded pipeline samples
38-
FROM registry.access.redhat.com/ubi9/python-39:9.5 as compiler
38+
FROM registry.access.redhat.com/ubi9/python-39:9.5 AS compiler
3939
USER root
4040
RUN dnf install -y python3-setuptools jq
4141
RUN wget https://bootstrap.pypa.io/get-pip.py && python3 get-pip.py
4242
COPY backend/requirements.txt .
4343
RUN python3 -m pip install -r requirements.txt --no-cache-dir
4444

4545
# Downloading Argo CLI so that the samples are validated
46-
ENV ARGO_VERSION v3.5.14
46+
ENV ARGO_VERSION=v3.5.14
4747
RUN curl -sLO https://github.com/argoproj/argo-workflows/releases/download/${ARGO_VERSION}/argo-linux-amd64.gz && \
4848
gunzip argo-linux-amd64.gz && \
4949
chmod +x argo-linux-amd64 && \

backend/Dockerfile.driver

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# Build arguments
1616
ARG SOURCE_CODE=.
1717

18-
FROM registry.access.redhat.com/ubi9/go-toolset:1.23 as builder
18+
FROM registry.access.redhat.com/ubi9/go-toolset:1.23 AS builder
1919

2020

2121
## Build args to be used at this step

backend/Dockerfile.launcher

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ ARG SOURCE_CODE=.
1717
ARG CI_CONTAINER_VERSION="unknown"
1818

1919

20-
FROM registry.access.redhat.com/ubi9/go-toolset:1.23 as builder
20+
FROM registry.access.redhat.com/ubi9/go-toolset:1.23 AS builder
2121

2222

2323
## Build args to be used at this step

backend/Dockerfile.persistenceagent

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
ARG SOURCE_CODE=.
1717
ARG CI_CONTAINER_VERSION="unknown"
1818

19-
FROM registry.access.redhat.com/ubi9/go-toolset:1.23 as builder
19+
FROM registry.access.redhat.com/ubi9/go-toolset:1.23 AS builder
2020

2121
## Build args to be used at this step
2222
ARG SOURCE_CODE
@@ -42,15 +42,15 @@ WORKDIR /bin
4242

4343
COPY --from=builder /bin/persistence_agent /bin/persistence_agent
4444

45-
ENV NAMESPACE ""
45+
ENV NAMESPACE=""
4646

4747
# Set Workflow TTL to 1 day. The way to use a different value for a particular Kubeflow Pipelines deployment is demonstrated in manifests/kustomize/base/pipeline/ml-pipeline-persistenceagent-deployment.yaml
48-
ENV TTL_SECONDS_AFTER_WORKFLOW_FINISH 86400
48+
ENV TTL_SECONDS_AFTER_WORKFLOW_FINISH=86400
4949

5050
# NUM_WORKERS indicates now many worker goroutines
51-
ENV NUM_WORKERS 2
52-
ENV LOG_LEVEL info
51+
ENV NUM_WORKERS=2
52+
ENV LOG_LEVEL=info
5353

54-
ENV EXECUTIONTYPE Workflow
54+
ENV EXECUTIONTYPE=Workflow
5555

5656
CMD persistence_agent --logtostderr=true --namespace=${NAMESPACE} --ttlSecondsAfterWorkflowFinish=${TTL_SECONDS_AFTER_WORKFLOW_FINISH} --numWorker ${NUM_WORKERS} --executionType ${EXECUTIONTYPE} --logLevel=${LOG_LEVEL}

backend/Dockerfile.scheduledworkflow

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# Build arguments
1616
ARG SOURCE_CODE=.
1717

18-
FROM registry.access.redhat.com/ubi9/go-toolset:1.23 as builder
18+
FROM registry.access.redhat.com/ubi9/go-toolset:1.23 AS builder
1919

2020
## Build args to be used at this step
2121
ARG SOURCE_CODE
@@ -51,7 +51,7 @@ RUN chmod +x /bin/controller
5151
RUN microdnf makecache && \
5252
microdnf install -y tzdata.noarch
5353

54-
ENV NAMESPACE ""
55-
ENV LOG_LEVEL info
54+
ENV NAMESPACE=""
55+
ENV LOG_LEVEL=info
5656

5757
CMD /bin/controller --logtostderr=true --namespace=${NAMESPACE} --logLevel=${LOG_LEVEL}

0 commit comments

Comments
 (0)