Skip to content

Commit 26affee

Browse files
committed
feat(backend/frontend): Add the name field for pipelines and pipeline versions (kubeflow#11952)
* Add the name field for pipelines and pipeline versions The API only accepted display_name, which accepted arbitrary characters but this does not work well in Kubernetes native API mode (Kubernetes pipeline store) since object names must be a valid DNS subdomain. This commit adds the name field which is required, but for backwards compatibility, the API will accept just name or display_name and duplicate the set value to the unset field. For existing users, they will only see that there is an extra field of "name" on pipelines and pipeline versions that is the same value as "display_name". The database migration logic adds a new DisplayName column and sets the values to what was in the Name column. Confusingly, the API field "display_name" used to map the a database column of "Name". The UI now handles both name and display name but for a simpler user experience, the display name form fields when uploading a pipeline are hidden when not in Kubernetes native API mode (Kubernetes pipeline store) since there is no need to have a display name since there is no naming restrictions on the name. Signed-off-by: mprahl <[email protected]> * Add a better API error when a Kubernetes object name is invalid Signed-off-by: mprahl <[email protected]> --------- Signed-off-by: mprahl <[email protected]>
1 parent 984bd3d commit 26affee

File tree

71 files changed

+1693
-504
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+1693
-504
lines changed

.github/workflows/e2e-test.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,7 @@ jobs:
222222
run: go test -v ./... -namespace kubeflow -args -runIntegrationTests=true
223223
env:
224224
PULL_NUMBER: ${{ github.event.pull_request.number }}
225+
PIPELINE_STORE: ${{ matrix.pipeline_store }}
225226
continue-on-error: true
226227

227228
- name: Collect failed logs

backend/api/v2beta1/go_client/healthz.pb.go

Lines changed: 32 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)