Skip to content

Commit 2829d61

Browse files
committed
UPSTREAM: <carry>: remove content disposition http header from artifact download
This header prevents an artifact from being previewed/rendered in an iframe. Remove it.
1 parent bbfb589 commit 2829d61

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

backend/src/apiserver/storage/object_store.go

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ package storage
1616

1717
import (
1818
"bytes"
19-
"fmt"
2019
"github.com/kubeflow/pipelines/backend/src/common/util"
2120
"github.com/kubeflow/pipelines/backend/src/v2/objectstore"
2221
minio "github.com/minio/minio-go/v6"
@@ -25,7 +24,6 @@ import (
2524
"path"
2625
"regexp"
2726
"sigs.k8s.io/yaml"
28-
"strings"
2927
"time"
3028
)
3129

@@ -139,15 +137,11 @@ func (m *MinioObjectStore) GetSignedUrl(bucketConfig *objectstore.Config, secret
139137
return "", err
140138
}
141139

142-
prefixSplit := strings.Split(bucketConfig.Prefix, "/")
143-
filename := prefixSplit[len(prefixSplit)-1]
144-
reqParams := make(url.Values)
145-
reqParams.Set("response-content-disposition", fmt.Sprintf("attachment; filename=\"%s\"", filename))
146-
147140
key, err := objectstore.ArtifactKeyFromURI(artifactURI)
148141
if err != nil {
149142
return "", err
150143
}
144+
reqParams := make(url.Values)
151145
signedUrl, err := s3Client.Presign("GET", bucketConfig.BucketName, key, expirySeconds, reqParams)
152146
if err != nil {
153147
return "", util.Wrap(err, "Failed to generate signed url")

0 commit comments

Comments
 (0)