Merge pull request #41 from HumairAK/fix_cc

UPSTREAM: <carry>: move commit checker to separate wf

Author: HumairAK

.github/workflows/build-prs-trigger.yaml

@@ -1,4 +1,4 @@
-name: Trigger build images for PRs
+name: Trigger PR CI
 on:
   pull_request:
     paths-ignore:

.github/workflows/build-prs.yml

@@ -1,7 +1,7 @@
 name: Build images for PRs
 on:
   workflow_run:
-    workflows: ["Trigger build images for PRs"]
+    workflows: ["Trigger PR CI"]
     types:
       - completed
 env:
@@ -11,37 +11,6 @@ env:
   GH_USER_EMAIL: [email protected]
   GH_USER_NAME: dsp-developers
 jobs:
-  commit_checker:
-    name: Run Commit Checker report
-    runs-on: ubuntu-latest
-    needs: build-pr-images
-    steps:
-      - uses: actions/checkout@v3
-      - name: Get Commits
-        id: get-commits
-        run: |
-          master_commit=$(cat .git/refs/remotes/origin/master)
-          echo "master_commit_hash=$master_commit" >> $GITHUB_OUTPUT
-          last_commit=$(cat .git/refs/remotes/pull/${{ github.event.pull_request.number }}/merge)
-          echo "last_commit_hash=$last_commit" >> $GITHUB_OUTPUT
-      - name: Run Commit Checker
-        shell: bash
-        env:
-          GH_TOKEN: ${{ secrets.GH_TOKEN_PROJECT_EDIT }}
-        continue-on-error: true
-        run: |
-          git config user.email "${{ env.GH_USER_EMAIL }}"
-          git config user.name "${{ env.GH_USER_NAME }}"
-
-          cat <<"EOF" >> /tmp/body-file.txt
-          Commit Checker results:
-          ==== These are the results of the commit checker scans         ====
-          ==== If these are not commits from upstream kfp, then          ====
-          ==== please ensure you adhere to the commit checker formatting ====
-          $(podman run -q -v ${{ github.workspace }}:/src/app-root quay.io/rmartine/commitchecker:latest --start ${{ steps.get-commits.outputs.master_commit_hash }} --end ${{ steps.get-commits.outputs.last_commit_hash }})
-          EOF
-
-          gh pr comment ${{ github.event.pull_request.number }} --body-file /tmp/body-file.txt
   fetch-data:
     name: Fetch workflow payload
     runs-on: ubuntu-latest

.github/workflows/commit-check-pr.yml

@@ -0,0 +1,91 @@
+name: Commit Checker for PRs
+on:
+  workflow_run:
+    workflows: ["Trigger PR CI"]
+    types:
+      - completed
+env:
+  QUAY_ORG: opendatahub
+  QUAY_ID: ${{ secrets.QUAY_ROBOT_USERNAME }}
+  QUAY_TOKEN: ${{ secrets.QUAY_ROBOT_TOKEN }}
+  GH_USER_EMAIL: [email protected]
+  GH_USER_NAME: dsp-developers
+jobs:
+  fetch-data:
+    name: Fetch workflow payload
+    runs-on: ubuntu-latest
+    if: >
+      github.event.workflow_run.event == 'pull_request' &&
+      github.event.workflow_run.conclusion == 'success'
+    outputs:
+      pr_state: ${{ steps.vars.outputs.pr_state }}
+      pr_number: ${{ steps.vars.outputs.pr_number }}
+      head_sha: ${{ steps.vars.outputs.head_sha }}
+      event_action: ${{ steps.vars.outputs.event_action }}
+    steps:
+      - name: 'Download artifact'
+        uses: actions/[email protected]
+        with:
+          script: |
+            var artifacts = await github.actions.listWorkflowRunArtifacts({
+               owner: context.repo.owner,
+               repo: context.repo.repo,
+               run_id: ${{github.event.workflow_run.id }},
+            });
+            var matchArtifact = artifacts.data.artifacts.filter((artifact) => {
+              return artifact.name == "pr"
+            })[0];
+            var download = await github.actions.downloadArtifact({
+               owner: context.repo.owner,
+               repo: context.repo.repo,
+               artifact_id: matchArtifact.id,
+               archive_format: 'zip',
+            });
+            var fs = require('fs');
+            fs.writeFileSync('${{github.workspace}}/pr.zip', Buffer.from(download.data));
+      - run: unzip pr.zip
+      - shell: bash
+        id: vars
+        run: |
+          pr_number=$(cat ./pr_number)
+          pr_state=$(cat ./pr_state)
+          head_sha=$(cat ./head_sha)
+          event_action=$(cat ./event_action)
+          echo "pr_number=${pr_number}" >> $GITHUB_OUTPUT
+          echo "pr_state=${pr_state}" >> $GITHUB_OUTPUT
+          echo "head_sha=${head_sha}" >> $GITHUB_OUTPUT
+          echo "event_action=${event_action}" >> $GITHUB_OUTPUT
+
+  commit_checker:
+    name: Run Commit Checker report
+    runs-on: ubuntu-latest
+    needs: fetch-data
+    env:
+      PR_NUMBER: ${{ needs.fetch-data.outputs.pr_number }}
+    steps:
+      - uses: actions/checkout@v3
+      - name: Get Commits
+        id: get-commits
+        run: |
+          master_commit=$(cat .git/refs/remotes/origin/master)
+          echo "master_commit_hash=$master_commit" >> $GITHUB_OUTPUT
+          last_commit=$(cat .git/refs/remotes/pull/${{ PR_NUMBER }}/merge)
+          echo "last_commit_hash=$last_commit" >> $GITHUB_OUTPUT
+      - name: Run Commit Checker
+        shell: bash
+        env:
+          GH_TOKEN: ${{ secrets.GH_TOKEN_PROJECT_EDIT }}
+        continue-on-error: true
+        run: |
+          git config user.email "${{ env.GH_USER_EMAIL }}"
+          git config user.name "${{ env.GH_USER_NAME }}"
+
+          cat <<"EOF" >> /tmp/body-file.txt
+          Commit Checker results:
+          ==== These are the results of the commit checker scans         ====
+          ==== If these are not commits from upstream kfp, then          ====
+          ==== please ensure you adhere to the commit checker formatting ====
+          $(podman run -q -v ${{ github.workspace }}:/src/app-root quay.io/rmartine/commitchecker:latest --start ${{ steps.get-commits.outputs.master_commit_hash }} --end ${{ steps.get-commits.outputs.last_commit_hash }})
+          EOF
+
+          gh pr comment ${{ PR_NUMBER }} --body-file /tmp/body-file.txt