Skip to content

Commit 37a7b4e

Browse files
authored
chore(test): Fixed namespace in tests (kubeflow#11545)
Signed-off-by: Helber Belmiro <[email protected]>
1 parent a81b513 commit 37a7b4e

File tree

3 files changed

+13
-9
lines changed

3 files changed

+13
-9
lines changed

.github/workflows/e2e-test.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,12 @@ jobs:
109109
- name: Forward API port
110110
run: ./.github/resources/scripts/forward-port.sh "kubeflow" "ml-pipeline" 8888 8888
111111

112+
- name: Forward MySQL port
113+
run: ./.github/resources/scripts/forward-port.sh "kubeflow" "mysql" 3306 3306
114+
112115
- name: API integration tests v1
113116
working-directory: ./backend/test/integration
114-
run: go test -v ./... -namespace ${NAMESPACE} -args -runIntegrationTests=true
117+
run: go test -v ./... -namespace kubeflow -args -runIntegrationTests=true
115118

116119
- name: Collect test results
117120
if: always()
@@ -145,7 +148,7 @@ jobs:
145148

146149
- name: API integration tests v2
147150
working-directory: ./backend/test/v2/integration
148-
run: go test -v ./... -namespace ${NAMESPACE} -args -runIntegrationTests=true
151+
run: go test -v ./... -namespace kubeflow -args -runIntegrationTests=true
149152

150153
- name: Collect test results
151154
if: always()

.github/workflows/upgrade-test.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,18 +33,21 @@ jobs:
3333
with:
3434
k8s_version: ${{ matrix.k8s_version }}
3535

36+
- name: Forward API port
37+
run: ./.github/resources/scripts/forward-port.sh "kubeflow" "ml-pipeline" 8888 8888
38+
3639
- name: Prepare upgrade tests
3740
working-directory: backend/test/integration
38-
run: go test -v ./... -namespace ${NAMESPACE} -args -runUpgradeTests=true -testify.m=Prepare
41+
run: go test -v ./... -namespace kubeflow -args -runUpgradeTests=true -testify.m=Prepare
3942

4043
- name: Prepare verification tests
4144
working-directory: backend/test/integration
42-
run: go test -v ./... -namespace ${NAMESPACE} -args -runUpgradeTests=true -testify.m=Verify
45+
run: go test -v ./... -namespace kubeflow -args -runUpgradeTests=true -testify.m=Verify
4346

4447
- name: Prepare upgrade tests v2
4548
working-directory: backend/test/v2/integration/
46-
run: go test -v ./... -namespace ${NAMESPACE} -args -runUpgradeTests=true -testify.m=Prepare
49+
run: go test -v ./... -namespace kubeflow -args -runUpgradeTests=true -testify.m=Prepare
4750

4851
- name: Prepare verification tests v2
4952
working-directory: backend/test/v2/integration
50-
run: go test -v ./... -namespace ${NAMESPACE} -args -runUpgradeTests=true -testify.m=Verify
53+
run: go test -v ./... -namespace kubeflow -args -runUpgradeTests=true -testify.m=Verify

backend/test/integration/db_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,7 @@ func (s *DBTestSuite) TestInitDBClient_MySQL() {
4848
viper.Set("DBDriverName", "mysql")
4949
viper.Set("DBConfig.MySQLConfig.DBName", "mlpipeline")
5050
// The default port-forwarding IP address that test uses is different compared to production
51-
if *localTest {
52-
viper.Set("DBConfig.MySQLConfig.Host", "localhost")
53-
}
51+
viper.Set("DBConfig.MySQLConfig.Host", "localhost")
5452
duration, _ := time.ParseDuration("1m")
5553
db := cm.InitDBClient(duration)
5654
assert.NotNil(t, db)

0 commit comments

Comments
 (0)