Merge pull request #73 from HumairAK/stable

Stable

Author: HumairAK

backend/src/apiserver/client/swf.go

@@ -61,7 +61,6 @@ func NewScheduledWorkflowClientOrFatal(initConnectionTimeout time.Duration, clie
 	if err == nil {
 		return swfClientInstance
 	}
-	glog.Infof("(Expected when in cluster) Failed to create scheduled workflow client by out of cluster kubeconfig. Error: %v", err)
 
 	glog.Infof("Starting to create scheduled workflow client by in cluster config.")
 	b := backoff.NewExponentialBackOff()

backend/src/apiserver/main.go

@@ -20,8 +20,6 @@ import (
 	"encoding/json"
 	"flag"
 	"fmt"
-	"github.com/kubeflow/pipelines/backend/src/apiserver/client"
-	"google.golang.org/grpc/credentials"
 	"io"
 	"io/ioutil"
 	"math"
@@ -32,6 +30,9 @@ import (
 	"strings"
 	"time"
 
+	"github.com/kubeflow/pipelines/backend/src/apiserver/client"
+	"google.golang.org/grpc/credentials"
+
 	"github.com/fsnotify/fsnotify"
 	"github.com/golang/glog"
 	"github.com/gorilla/mux"
@@ -98,13 +99,13 @@ func main() {
 	)
 	err = loadSamples(resourceManager)
 	if err != nil {
-		glog.Fatalf("Failed to load samples. Err: %v", err)
+		glog.Infof("Couldn't load optional pipeline samples: %v", err)
 	}
 
 	if !common.IsMultiUserMode() {
 		_, err = resourceManager.CreateDefaultExperiment("")
 		if err != nil {
-			glog.Fatalf("Failed to create default experiment. Err: %v", err)
+			glog.Infof("Couldn't create optional default experiment: %v", err)
 		}
 	}
 

backend/src/apiserver/storage/object_store.go

@@ -16,7 +16,6 @@ package storage
 
 import (
 	"bytes"
-	"fmt"
 	"github.com/kubeflow/pipelines/backend/src/common/util"
 	"github.com/kubeflow/pipelines/backend/src/v2/objectstore"
 	minio "github.com/minio/minio-go/v6"
@@ -25,7 +24,6 @@ import (
 	"path"
 	"regexp"
 	"sigs.k8s.io/yaml"
-	"strings"
 	"time"
 )
 
@@ -139,15 +137,11 @@ func (m *MinioObjectStore) GetSignedUrl(bucketConfig *objectstore.Config, secret
 		return "", err
 	}
 
-	prefixSplit := strings.Split(bucketConfig.Prefix, "/")
-	filename := prefixSplit[len(prefixSplit)-1]
-	reqParams := make(url.Values)
-	reqParams.Set("response-content-disposition", fmt.Sprintf("attachment; filename=\"%s\"", filename))
-
 	key, err := objectstore.ArtifactKeyFromURI(artifactURI)
 	if err != nil {
 		return "", err
 	}
+	reqParams := make(url.Values)
 	signedUrl, err := s3Client.Presign("GET", bucketConfig.BucketName, key, expirySeconds, reqParams)
 	if err != nil {
 		return "", util.Wrap(err, "Failed to generate signed url")