feat(backend): Allow the launcher command to be configurable (kubeflow#11888)

This allows the launcher command to be overridden with
the V2_LAUNCHER_COMMAND environment variable. This is useful if you need
to override the command to launch Delve for debugging or you have a
situation that requires using a different binary in the container image
based on the environment.

Signed-off-by: mprahl <[email protected]>
(cherry picked from commit 70d2888)

Author: mprahl

backend/src/v2/compiler/argocompiler/argo.go

@@ -19,9 +19,10 @@ import (
 	"encoding/hex"
 	"encoding/json"
 	"fmt"
-	"github.com/kubeflow/pipelines/backend/src/apiserver/common"
 	"strings"
 
+	"github.com/kubeflow/pipelines/backend/src/apiserver/common"
+
 	wfapi "github.com/argoproj/argo-workflows/v3/pkg/apis/workflow/v1alpha1"
 	"github.com/kubeflow/pipelines/api/v2alpha1/go/pipelinespec"
 	"github.com/kubeflow/pipelines/backend/src/v2/compiler"
@@ -134,12 +135,13 @@ func Compile(jobArg *pipelinespec.PipelineJob, kubernetesSpecArg *pipelinespec.S
 		wf:        wf,
 		templates: make(map[string]*wfapi.Template),
 		// TODO(chensun): release process and update the images.
-		launcherImage: GetLauncherImage(),
-		driverImage:   GetDriverImage(),
-		driverCommand: GetDriverCommand(),
-		job:           job,
-		spec:          spec,
-		executors:     deploy.GetExecutors(),
+		launcherImage:   GetLauncherImage(),
+		launcherCommand: GetLauncherCommand(),
+		driverImage:     GetDriverImage(),
+		driverCommand:   GetDriverCommand(),
+		job:             job,
+		spec:            spec,
+		executors:       deploy.GetExecutors(),
 	}
 
 	mlPipelineTLSEnabled, err := GetMLPipelineServiceTLSEnabled()
@@ -182,6 +184,7 @@ type workflowCompiler struct {
 	driverImage                 string
 	driverCommand               []string
 	launcherImage               string
+	launcherCommand             []string
 	mlPipelineServiceTLSEnabled bool
 }
 

backend/src/v2/compiler/argocompiler/container.go

@@ -35,6 +35,8 @@ const (
 	volumeNameCABundle       = "ca-bundle"
 	DefaultLauncherImage     = "ghcr.io/kubeflow/kfp-launcher:2.4.0"
 	LauncherImageEnvVar      = "V2_LAUNCHER_IMAGE"
+	LauncherCommandEnvVar    = "V2_LAUNCHER_COMMAND"
+	DefaultLauncherCommand   = "launcher-v2"
 	DefaultDriverImage       = "ghcr.io/kubeflow/kfp-driver:2.4.0"
 	DriverImageEnvVar        = "V2_DRIVER_IMAGE"
 	DefaultDriverCommand     = "driver"
@@ -106,6 +108,14 @@ func GetDriverCommand() []string {
 	return strings.Split(driverCommand, " ")
 }
 
+func GetLauncherCommand() []string {
+	launcherCommand := os.Getenv(LauncherCommandEnvVar)
+	if launcherCommand == "" {
+		launcherCommand = DefaultLauncherCommand
+	}
+	return strings.Split(launcherCommand, " ")
+}
+
 func GetPipelineRunAsUser() *int64 {
 	runAsUserStr := os.Getenv(PipelineRunAsUserEnvVar)
 	if runAsUserStr == "" {
@@ -370,7 +380,7 @@ func (c *workflowCompiler) addContainerExecutorTemplate(refName string) string {
 			Container: k8score.Container{
 				Name:    "kfp-launcher",
 				Image:   c.launcherImage,
-				Command: []string{"launcher-v2"},
+				Command: c.launcherCommand,
 				Args:    args,
 				VolumeMounts: []k8score.VolumeMount{
 					{

backend/src/v2/compiler/argocompiler/importer.go

@@ -99,7 +99,7 @@ func (c *workflowCompiler) addImporterTemplate() string {
 		},
 		Container: &k8score.Container{
 			Image:     c.launcherImage,
-			Command:   []string{"launcher-v2"},
+			Command:   c.launcherCommand,
 			Args:      args,
 			EnvFrom:   []k8score.EnvFromSource{metadataEnvFrom},
 			Env:       commonEnvs,