Skip to content

Commit 7d8e921

Browse files
authored
Fix format string in get_kfp_package_path (kubeflow#11712)
* Fix format string in get_kfp_package_path Signed-off-by: mprahl <[email protected]> * Use the in repo SDK for "k8s execution tests" Signed-off-by: mprahl <[email protected]> --------- Signed-off-by: mprahl <[email protected]>
1 parent 355f78c commit 7d8e921

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

.github/workflows/kfp-kubernetes-execution-tests.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,9 @@ jobs:
7474

7575
- name: Run tests
7676
id: test
77+
env:
78+
PULL_NUMBER: ${{ github.event.pull_request.number }}
79+
REPO_NAME: ${{ github.repository }}
7780
run: |
7881
export KFP_ENDPOINT="http://localhost:8888"
7982
export TIMEOUT_SECONDS=2700

test/kfp-kubernetes-execution-tests/sdk_execution_tests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ def get_kfp_package_path() -> str:
114114
if os.environ.get('PULL_NUMBER') is not None:
115115
path = f'git+https://github.com/{repo_name}.git@refs/pull/{os.environ["PULL_NUMBER"]}/merge#subdirectory=sdk/python'
116116
else:
117-
path = 'git+https://github.com/{repo_name}.git@master#subdirectory=sdk/python'
117+
path = f'git+https://github.com/{repo_name}.git@master#subdirectory=sdk/python'
118118
print(f'Using the following KFP package path for tests: {path}')
119119
return path
120120

test/sdk-execution-tests/sdk_execution_tests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ def get_kfp_package_path() -> str:
103103
if os.environ.get('PULL_NUMBER') is not None:
104104
path = f'git+https://github.com/{repo_name}.git@refs/pull/{os.environ["PULL_NUMBER"]}/merge#subdirectory=sdk/python'
105105
else:
106-
path = 'git+https://github.com/{repo_name}.git@master#subdirectory=sdk/python'
106+
path = f'git+https://github.com/{repo_name}.git@master#subdirectory=sdk/python'
107107
print(f'Using the following KFP package path for tests: {path}')
108108
return path
109109

0 commit comments

Comments
 (0)