UPSTREAM: 11578: fix(backend): Replaced hardcoded ServiceAccount with default config

Signed-off-by: Helber Belmiro <[email protected]>

Author: hbelmiro

backend/src/apiserver/resource/resource_manager_test.go

@@ -2401,6 +2401,40 @@ func TestCreateJob_ThroughWorkflowSpecV2(t *testing.T) {
 	assert.Equal(t, expectedJob.ToV1(), fetchedJob.ToV1(), "CreateJob stored invalid data in database")
 }
 
+func TestCreateJobDifferentDefaultServiceAccountName_ThroughWorkflowSpecV2(t *testing.T) {
+	originalDefaultServiceAccount := viper.Get(common.DefaultPipelineRunnerServiceAccountFlag)
+
+	viper.Set(common.DefaultPipelineRunnerServiceAccountFlag, "my-service-account")
+	defer viper.Set(common.DefaultPipelineRunnerServiceAccountFlag, originalDefaultServiceAccount)
+
+	store, manager, job := initWithJobV2(t)
+	defer store.Close()
+	expectedJob := &model.Job{
+		UUID:           "123e4567-e89b-12d3-a456-426655440000",
+		DisplayName:    "j1",
+		K8SName:        "job-",
+		Namespace:      "ns1",
+		ServiceAccount: "my-service-account",
+		Enabled:        true,
+		ExperimentId:   DefaultFakeUUID,
+		CreatedAtInSec: 2,
+		UpdatedAtInSec: 2,
+		Conditions:     "STATUS_UNSPECIFIED",
+		PipelineSpec: model.PipelineSpec{
+			PipelineSpecManifest: v2SpecHelloWorld,
+			RuntimeConfig: model.RuntimeConfig{
+				Parameters:   "{\"text\":\"world\"}",
+				PipelineRoot: "job-1-root",
+			},
+		},
+	}
+	expectedJob.PipelineSpec.PipelineName = job.PipelineSpec.PipelineName
+	require.Equal(t, expectedJob.ToV1(), job.ToV1())
+	fetchedJob, err := manager.GetJob(job.UUID)
+	require.Nil(t, err)
+	require.Equal(t, expectedJob.ToV1(), fetchedJob.ToV1(), "CreateJob stored invalid data in database")
+}
+
 func TestCreateJob_ThroughPipelineID(t *testing.T) {
 	store, manager, pipeline, _ := initWithPipeline(t)
 	defer store.Close()

backend/src/v2/compiler/argocompiler/argo.go

@@ -16,6 +16,7 @@ package argocompiler
 
 import (
 	"fmt"
+	"github.com/kubeflow/pipelines/backend/src/apiserver/common"
 	"strings"
 
 	wfapi "github.com/argoproj/argo-workflows/v3/pkg/apis/workflow/v1alpha1"
@@ -63,7 +64,7 @@ func Compile(jobArg *pipelinespec.PipelineJob, kubernetesSpecArg *pipelinespec.S
 	if err != nil {
 		return nil, err
 	}
-	// fill root component default paramters to PipelineJob
+	// fill root component default parameters to PipelineJob
 	specParams := spec.GetRoot().GetInputDefinitions().GetParameters()
 	for name, param := range specParams {
 		_, ok := job.RuntimeConfig.ParameterValues[name]
@@ -108,7 +109,7 @@ func Compile(jobArg *pipelinespec.PipelineJob, kubernetesSpecArg *pipelinespec.S
 					"pipelines.kubeflow.org/v2_component": "true",
 				},
 			},
-			ServiceAccountName: "pipeline-runner",
+			ServiceAccountName: common.GetStringConfigWithDefault(common.DefaultPipelineRunnerServiceAccountFlag, common.DefaultPipelineRunnerServiceAccount),
 			Entrypoint:         tmplEntrypoint,
 		},
 	}