Skip to content

Commit dd29e6c

Browse files
committed
switch selenium image to ghcr
(cherry picked from commit 7529bbe) Signed-off-by: Humair Khan <[email protected]>
1 parent 3a61807 commit dd29e6c

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

backend/api/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,6 @@ API generator image is defined in [Dockerfile](`./Dockerfile`). If you need to u
8484
1. Login to GHCR container registry: `echo "<PAT>" | docker login ghcr.io -u <USERNAME> --password-stdin`
8585
* Replace `<PAT>` with a GitHub Personal Access Token (PAT) with the write:packages and `read:packages` scopes, as well as `delete:packages` if needed.
8686
1. Update the [Dockerfile](`./Dockerfile`) and build the image by running `docker build -t ghcr.io/kubeflow/kfp-api-generator:$VERSION .`
87-
1. Push the new container by running `docker push ghcr.io/kubeflow/kfp-api-generator:$VERSION` (requires to be [authenticated](https://cloud.google.com/container-registry/docs/advanced-authentication)).
87+
1. Push the new container by running `docker push ghcr.io/kubeflow/kfp-api-generator:$VERSION`.
8888
1. Update the `PREBUILT_REMOTE_IMAGE` variable in the [Makefile](./Makefile) to point to your new image.
8989
1. Similarly, push a new version of the release tools image to `ghcr.io/kubeflow/kfp-release:$VERSION` and run `make push` in [test/release/Makefile](../../test/release/Makefile).

test/frontend-integration-test/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM gcr.io/ml-pipeline-test/selenium-standalone-chrome-gcloud-nodejs:v20230322-2.0.0b11-144-g87e1c5fcf-dirty-2ca4f7
1+
FROM ghcr.io/kubeflow/kfp-selenium-standalone-chrome-gcloud-nodejs:main-e21bbbaf225dc0d5470df55d6d7254b7e2dd066c
22
#To build this image: cd selenium-standalone-chrome-gcloud-nodejs.Docker && make push
33

44
COPY --chown=seluser . /src
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
### Build and Push this image to KFP GHCR
2+
3+
1. Login to GHCR container registry: `echo "<PAT>" | docker login ghcr.io -u <USERNAME> --password-stdin`
4+
* Replace `<PAT>` with a GitHub Personal Access Token (PAT) with the write:packages and `read:packages` scopes, as well as `delete:packages` if needed.
5+
1. Set `TAG=` to `main-<commit-hash>` where `<commit-hash>` is the commit used to build the image on (your current HEAD)/
6+
1. Update the [Dockerfile](`./Dockerfile`) and build the image by running `docker build -t ghcr.io/kubeflow/kfp-selenium-standalone-chrome-gcloud-nodejs:$TAG .`
7+
1. Push the new container by running `docker push ghcr.io/kubeflow/kfp-selenium-standalone-chrome-gcloud-nodejs:$TAG`.
8+
1. Update the version in front end integration [Dockerfile](test/frontend-integration-test/Dockerfile) to point to your new image.

0 commit comments

Comments
 (0)