Skip to content

Commit e696472

Browse files
authored
chore(backend): Optimized Dockerfiles (kubeflow#11834)
Signed-off-by: Helber Belmiro <[email protected]>
1 parent 924b13c commit e696472

File tree

4 files changed

+16
-16
lines changed

4 files changed

+16
-16
lines changed

backend/Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,15 +64,15 @@ ENV LOG_LEVEL info
6464

6565
WORKDIR /bin
6666

67+
# Adding CA certificate so API server can download pipeline through URL and wget is used for liveness/readiness probe command
68+
RUN apt-get update && apt-get install -y ca-certificates wget
69+
6770
COPY backend/src/apiserver/config/ /config
6871
COPY --from=builder /bin/apiserver /bin/apiserver
6972

7073
COPY --from=compiler /samples/ /samples/
7174
RUN chmod +x /bin/apiserver
7275

73-
# Adding CA certificate so API server can download pipeline through URL and wget is used for liveness/readiness probe command
74-
RUN apt-get update && apt-get install -y ca-certificates wget
75-
7676
# Pin sample doc links to the commit that built the backend image
7777
RUN sed -E "s#/(blob|tree)/master/#/\1/${COMMIT_SHA}/#g" -i /config/sample_config.json && \
7878
sed -E "s/%252Fmaster/%252F${COMMIT_SHA}/#g" -i /config/sample_config.json

backend/Dockerfile.persistenceagent

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@
1414

1515
FROM golang:1.23-alpine as builder
1616

17+
# Needed musl-dev for github.com/mattn/go-sqlite3
18+
RUN apk update && apk upgrade && \
19+
apk add --no-cache bash git openssh gcc musl-dev
20+
1721
WORKDIR /go/src/github.com/kubeflow/pipelines
1822

1923
COPY ./go.mod ./
@@ -25,10 +29,6 @@ RUN GO111MODULE=on go mod download
2529

2630
COPY . .
2731

28-
# Needed musl-dev for github.com/mattn/go-sqlite3
29-
RUN apk update && apk upgrade && \
30-
apk add --no-cache bash git openssh gcc musl-dev
31-
3232
RUN GO111MODULE=on go build -o /bin/persistence_agent backend/src/agent/persistence/*.go
3333

3434
FROM alpine:3.19

backend/Dockerfile.scheduledworkflow

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@
1414

1515
FROM golang:1.23-alpine as builder
1616

17+
# Needed musl-dev for github.com/mattn/go-sqlite3
18+
RUN apk update && apk upgrade && \
19+
apk add --no-cache bash git openssh gcc musl-dev
20+
1721
WORKDIR /go/src/github.com/kubeflow/pipelines
1822

1923
COPY ./go.mod ./
@@ -25,10 +29,6 @@ RUN GO111MODULE=on go mod download
2529

2630
COPY . .
2731

28-
# Needed musl-dev for github.com/mattn/go-sqlite3
29-
RUN apk update && apk upgrade && \
30-
apk add --no-cache bash git openssh gcc musl-dev
31-
3232
RUN GO111MODULE=on go build -o /bin/controller backend/src/crd/controller/scheduledworkflow/*.go
3333

3434
FROM alpine:3.19

backend/Dockerfile.visualization

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@
2121
FROM tensorflow/tensorflow:2.10.1
2222

2323
RUN apt-get update \
24-
&& apt-get install -y wget curl tar openssl
24+
&& apt-get install -y wget curl tar openssl \
25+
&& curl https://dl.google.com/dl/cloudsdk/release/google-cloud-sdk.tar.gz > /tmp/google-cloud-sdk.tar.gz \
26+
&& mkdir -p /usr/local/gcloud \
27+
&& tar -C /usr/local/gcloud -xf /tmp/google-cloud-sdk.tar.gz \
28+
&& /usr/local/gcloud/google-cloud-sdk/install.sh \
2529

26-
RUN curl https://dl.google.com/dl/cloudsdk/release/google-cloud-sdk.tar.gz > /tmp/google-cloud-sdk.tar.gz
27-
RUN mkdir -p /usr/local/gcloud
28-
RUN tar -C /usr/local/gcloud -xf /tmp/google-cloud-sdk.tar.gz
29-
RUN /usr/local/gcloud/google-cloud-sdk/install.sh
3030
ENV PATH $PATH:/usr/local/gcloud/google-cloud-sdk/bin
3131

3232
WORKDIR /src

0 commit comments

Comments
 (0)