Skip to content

Commit 571d81f

Browse files
fix: Dask pulling of latest data (feast-dev#5229)
Signed-off-by: Suraj Patil <[email protected]>
1 parent 0d05701 commit 571d81f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

sdk/python/feast/infra/offline_stores/dask.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -365,13 +365,13 @@ def evaluate_offline_job():
365365
if start_date and end_date:
366366
source_df = source_df[
367367
source_df[timestamp_field].between(
368-
start_date, end_date, inclusive="left"
368+
start_date, end_date, inclusive="both"
369369
)
370370
]
371371
elif start_date:
372372
source_df = source_df[source_df[timestamp_field] >= start_date]
373373
elif end_date:
374-
source_df = source_df[source_df[timestamp_field] < end_date]
374+
source_df = source_df[source_df[timestamp_field] <= end_date]
375375

376376
source_df = source_df.persist()
377377

sdk/python/tests/utils/feature_records.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,7 @@ def get_last_feature_row(df: pd.DataFrame, driver_id, max_date: datetime):
519519
"""Manually extract last feature value from a dataframe for a given driver_id with up to `max_date` date"""
520520
filtered = df[
521521
(df["driver_id"] == driver_id)
522-
& (df["event_timestamp"] < max_date.replace(tzinfo=timezone.utc))
522+
& (df["event_timestamp"] <= max_date.replace(tzinfo=timezone.utc))
523523
]
524524
max_ts = filtered.loc[filtered["event_timestamp"].idxmax()]["event_timestamp"]
525525
filtered_by_ts = filtered[filtered["event_timestamp"] == max_ts]

0 commit comments

Comments
 (0)