Skip to content

Commit d6f4b4e

Browse files
aniketpaluntkathole
authored andcommitted
Providing warning instead of raising error due to chances of breaking other functionalities
Signed-off-by: Aniket Paluskar <[email protected]>
1 parent a2e5c3e commit d6f4b4e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

sdk/python/feast/feature_store.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1900,14 +1900,14 @@ def write_to_online_store(
19001900
# Validate that the dataframe has meaningful feature data
19011901
if df is not None:
19021902
if df.empty:
1903-
raise ValueError("Cannot write empty dataframe to online store")
1903+
warnings.warn("Cannot write empty dataframe to online store")
19041904

19051905
# Check if feature columns are empty (entity columns may have data but feature columns are empty)
19061906
feature_column_names = [f.name for f in feature_view.features]
19071907
if feature_column_names:
19081908
feature_df = df[feature_column_names]
19091909
if feature_df.empty or feature_df.isnull().all().all():
1910-
raise ValueError(
1910+
warnings.warn(
19111911
"Cannot write dataframe with empty feature columns to online store"
19121912
)
19131913

@@ -1944,14 +1944,14 @@ async def write_to_online_store_async(
19441944
# Validate that the dataframe has meaningful feature data
19451945
if df is not None:
19461946
if df.empty:
1947-
raise ValueError("Cannot write empty dataframe to online store")
1947+
warnings.warn("Cannot write empty dataframe to online store")
19481948

19491949
# Check if feature columns are empty (entity columns may have data but feature columns are empty)
19501950
feature_column_names = [f.name for f in feature_view.features]
19511951
if feature_column_names:
19521952
feature_df = df[feature_column_names]
19531953
if feature_df.empty or feature_df.isnull().all().all():
1954-
raise ValueError(
1954+
warnings.warn(
19551955
"Cannot write dataframe with empty feature columns to online store"
19561956
)
19571957

0 commit comments

Comments
 (0)