Merge pull request #578 from jiridanek/jd_webhook_no_restart_otel

RHOAIENG-13916: chore(odh-notebook-controller/tests): define constant for the tracing event

Author: openshift-merge-bot[bot]

components/odh-notebook-controller/controllers/notebook_webhook.go

@@ -68,6 +68,10 @@ var getWebhookTracer func() trace.Tracer = sync.OnceValue(func() trace.Tracer {
 	return otel.GetTracerProvider().Tracer("opendatahub.io/kubeflow/components/odh-notebook-controller/controllers/notebook_webhook.go")
 })
 
+const (
+	IMAGE_STREAM_NOT_FOUND_EVENT = "imagestream-not-found"
+)
+
 // InjectReconciliationLock injects the kubeflow notebook controller culling
 // stop annotation to explicitly start the notebook pod when the ODH notebook
 // controller finishes the reconciliation. Otherwise, a race condition may happen
@@ -742,7 +746,7 @@ func SetContainerImageFromRegistry(ctx context.Context, config *rest.Config, not
 						}
 					}
 					if !imagestreamFound {
-						span.AddEvent("imagestream-not-found")
+						span.AddEvent(IMAGE_STREAM_NOT_FOUND_EVENT)
 						log.Error(nil, "ImageStream not found in main controller namespace, or the ImageStream is present but does not contain a dockerImageReference for the specified tag",
 							"imageSelected", imageSelected[0], "tag", imageSelected[1], "namespace", namespace)
 					}

components/odh-notebook-controller/controllers/notebook_webhook_test.go

@@ -113,7 +113,7 @@ var _ = Describe("The Openshift Notebook webhook", func() {
 				},
 				expectedImage: "quay.io/modh/odh-generic-data-science-notebook@sha256:76e6af79c601a323f75a58e7005de0beac66b8cccc3d2b67efb6d11d85f0cfa1",
 				unexpectedEvents: []string{
-					"imagestream-not-found",
+					IMAGE_STREAM_NOT_FOUND_EVENT,
 				},
 			},
 			{
@@ -165,7 +165,7 @@ var _ = Describe("The Openshift Notebook webhook", func() {
 				// there is no update to the Notebook
 				expectedImage: ":some-tag",
 				expectedEvents: []string{
-					"imagestream-not-found",
+					IMAGE_STREAM_NOT_FOUND_EVENT,
 				},
 			},
 		}