Skip to content

Commit 8ae9c53

Browse files
committed
[RHOAIENG-31618] extract the oauth proxy image into params.env file
This is to enable automate update in the product builds. We still have a reference of the oauth proxy image in the notebook_oauth.go file. It is used as a fallback if the --oauth-proxy-image argument isn't given to the manager process.
1 parent d3e1729 commit 8ae9c53

File tree

3 files changed

+16
-1
lines changed

3 files changed

+16
-1
lines changed

components/odh-notebook-controller/config/base/kustomization.yaml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,3 +25,17 @@ replacements:
2525
name: manager
2626
namespace: system
2727
version: v1
28+
- source:
29+
fieldPath: data.oauth-proxy-image
30+
kind: ConfigMap
31+
name: odh-notebook-controller-image-parameters
32+
version: v1
33+
targets:
34+
- fieldPaths:
35+
- spec.template.spec.containers.0.args.1
36+
select:
37+
group: apps
38+
kind: Deployment
39+
name: manager
40+
namespace: system
41+
version: v1
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
odh-notebook-controller-image=quay.io/opendatahub/odh-notebook-controller:main
2+
oauth-proxy-image=registry.redhat.io/openshift4/ose-oauth-proxy-rhel9@sha256:ca21e218e26c46e3c63d926241846f8f307fd4a586cc4b04147da49af6018ef5

components/odh-notebook-controller/config/manager/manager.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ spec:
2525
imagePullPolicy: Always
2626
command:
2727
- /manager
28-
args: ["--oauth-proxy-image", "registry.redhat.io/openshift4/ose-oauth-proxy-rhel9@sha256:ca21e218e26c46e3c63d926241846f8f307fd4a586cc4b04147da49af6018ef5"]
28+
args: ["--oauth-proxy-image", "oauth-proxy-image_PLACEHOLDER"]
2929
securityContext:
3030
allowPrivilegeEscalation: false
3131
ports:

0 commit comments

Comments
 (0)