Skip to content

Commit 956a064

Browse files
committed
fixup! commit the tests themselves, using ginkgo v1
add missing err checks
1 parent a29ab7f commit 956a064

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

components/odh-notebook-controller/upgrade/controller_upgrade_test.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ var _ = It("Upgrade from RHOAI 2.13", func() {
4040

4141
By("deploying the dumped 2.13 YAMLs", func() {
4242
dyn, err := dynamic.NewForConfig(cfg)
43+
Expect(err).To(Succeed())
4344

4445
// prepare a RESTMapper to find GVRs
4546
dc, err := discovery.NewDiscoveryClientForConfig(cfg)
@@ -242,10 +243,7 @@ func applyYamlDirectory(dyn *dynamic.DynamicClient, mapper *restmapper.DeferredD
242243
obj.SetUID(created.GetUID())
243244
obj.SetResourceVersion(created.GetResourceVersion())
244245
_, err = dyn.Resource(mapping.Resource).Namespace("developer").UpdateStatus(context.TODO(), obj, metav1.UpdateOptions{})
245-
//if err != nil {
246-
// panic(err)
247-
//}
248-
//Expect(err).To(Succeed())
246+
Expect(err).To(Succeed())
249247
}
250248
}
251249

0 commit comments

Comments
 (0)