fix: add nil checks to prevent unit tests from failing

rkpattnaik780 · rkpattnaik780 · commit c25281ef64e4 · 2024-04-09T15:41:44.000+05:30
diff --git a/components/notebook-controller/controllers/notebook_controller.go b/components/notebook-controller/controllers/notebook_controller.go
@@ -162,7 +162,7 @@ func (r *NotebookReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c
 
 	// Copy the pod template labels, but reconcilation is not required
 	// exclusively based on ths pod template labels
-	if *ss.Spec.Replicas != *foundStateful.Spec.Replicas {
+	if ss.Spec.Replicas != nil && foundStateful.Spec.Replicas != nil && *ss.Spec.Replicas != *foundStateful.Spec.Replicas {
 		if !reflect.DeepEqual(foundStateful.Spec.Template.ObjectMeta.Labels, ss.Spec.Template.ObjectMeta.Labels) {
 			foundStateful.Spec.Template.ObjectMeta.Labels = ss.Spec.Template.ObjectMeta.Labels
 		}

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ func (r *NotebookReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c`
`162`	`162`
`163`	`163`	`// Copy the pod template labels, but reconcilation is not required`
`164`	`164`	`// exclusively based on ths pod template labels`
`165`		`- if ss.Spec.Replicas != foundStateful.Spec.Replicas {`
	`165`	`+ if ss.Spec.Replicas != nil && foundStateful.Spec.Replicas != nil && ss.Spec.Replicas != foundStateful.Spec.Replicas {`
`166`	`166`	`if !reflect.DeepEqual(foundStateful.Spec.Template.ObjectMeta.Labels, ss.Spec.Template.ObjectMeta.Labels) {`
`167`	`167`	`foundStateful.Spec.Template.ObjectMeta.Labels = ss.Spec.Template.ObjectMeta.Labels`
`168`	`168`	`}`