RHOAIENG-9374: specify relative paths for sibling Kubeflow dependencies

Previously,
notebook-controller downloaded kubflow/common from the net,
similarly,
odh-notebook-controller dowloaded a version of kubeflow/notebook-controller from the net.
With this change,
all Kubeflow code comes from the components/ directory in this repo.

This gives us more control over the Kubeflow code we use.

---

# Reconciling changes

## kubeflow/components/common

$ go install golang.org/dl/go1.20.14@latest
$ ~/go/bin/go1.20.14 download

kubeflow/components/notebook-controller$ ~/go/bin/go1.20.14 get github.com/kubeflow/kubeflow/components/[email protected]
$ idea diff ../common ~/go/pkg/mod/github.com/kubeflow/kubeflow/components/[email protected]

```
diff ../common ~/go/pkg/mod/github.com/kubeflow/kubeflow/components/[email protected]
diff ../common/go.mod /home/jdanek/go/pkg/mod/github.com/kubeflow/kubeflow/components/[email protected]/go.mod
3c3
< go 1.19
---
> go 1.12
Only in /home/jdanek/go/pkg/mod/github.com/kubeflow/kubeflow/components/[email protected]: LICENSE
Common subdirectories: ../common/reconcilehelper and /home/jdanek/go/pkg/mod/github.com/kubeflow/kubeflow/components/[email protected]/reconcilehelpe
```

There are no meaningful differences, so no changes necessary. Great.

## kubeflow/components/notebook-controller

kubeflow/components/odh-notebook-controller$ ~/go/bin/go1.20.14 get github.com/kubeflow/kubeflow/components/[email protected]
$ idea diff ../notebook-controller ~/go/pkg/mod/github.com/kubeflow/kubeflow/components/[email protected]

Looking at the usages, it seems clear to me that we want to use what's in our repo in components/notebook-controller/pkg/culler. This is because odh-notebook-controller only imports culler to get at `culler.STOP_ANNOTATION`. This constant is the same in both versions.

Therefore, also no further changes are needed.

Author: jiridanek

.github/workflows/notebook_controller_integration_test.yaml

@@ -7,6 +7,7 @@ on:
       - v1.10-branch
     paths:
       - .github/workflows/notebook_controller_integration_test.yaml
+      - components/common/**
       - components/notebook-controller/**
   workflow_dispatch:
 

.github/workflows/notebook_controller_unit_test.yaml

@@ -7,6 +7,7 @@ on:
       - v1.10-branch
     paths:
       - .github/workflows/notebook_controller_unit_test.yaml
+      - components/common/**
       - components/notebook-controller/**
   workflow_dispatch:
 

.github/workflows/odh_notebook_controller_integration_test.yaml

@@ -7,6 +7,7 @@ on:
       - v1.10-branch
     paths:
       - .github/workflows/odh_notebook_controller_integration_test.yaml
+      - components/common/**
       - components/notebook-controller/**
       - components/odh-notebook-controller/**
   workflow_dispatch:

.github/workflows/odh_notebook_controller_unit_test.yaml

@@ -7,6 +7,8 @@ on:
       - v1.10-branch
     paths:
       - .github/workflows/odh_notebook_controller_unit_test.yaml
+      - components/common/**
+      - components/notebook-controller/**
       - components/odh-notebook-controller/**
   workflow_dispatch:
 

components/notebook-controller/go.mod

@@ -75,4 +75,7 @@ require (
 	sigs.k8s.io/yaml v1.4.0 // indirect
 )
 
+// use sibling kubeflow packages from this repo
+replace github.com/kubeflow/kubeflow/components/common => ../common
+
 replace google.golang.org/grpc => google.golang.org/grpc v1.56.3

components/notebook-controller/go.sum

@@ -75,8 +75,6 @@ github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ=
 github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI=
 github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
 github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
-github.com/kubeflow/kubeflow/components/common v0.0.0-20220218084159-4ad0158e955e h1:Ud6a+mkZ5pj+QqZnsIPPBk1WrABz1wYcd1n9CYjMMBA=
-github.com/kubeflow/kubeflow/components/common v0.0.0-20220218084159-4ad0158e955e/go.mod h1:uj1ImonZ+hHqWKfzZGWjuxl1uODjubBNrg4W8c38/ts=
 github.com/mailru/easyjson v0.7.7 h1:UGYAvKxe3sBsEDzO8ZeWOSlIQfWFlxbzLZe7hwFURr0=
 github.com/mailru/easyjson v0.7.7/go.mod h1:xzfreul335JAWq5oZzymOObrkdz5UnU4kGfJJLY9Nlc=
 github.com/matttproud/golang_protobuf_extensions/v2 v2.0.0 h1:jWpvCLoY8Z/e3VKvlsiIGKtc+UG6U5vzxaoagmhXfyg=

components/odh-notebook-controller/go.mod

@@ -88,4 +88,7 @@ require (
 	sigs.k8s.io/yaml v1.4.0 // indirect
 )
 
+// use sibling kubeflow packages from this repo
+replace github.com/kubeflow/kubeflow/components/notebook-controller => ../notebook-controller
+
 replace google.golang.org/grpc => google.golang.org/grpc v1.56.3

components/odh-notebook-controller/go.sum

@@ -78,8 +78,6 @@ github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ=
 github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI=
 github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
 github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
-github.com/kubeflow/kubeflow/components/notebook-controller v0.0.0-20220728153354-fc09bd1eefb8 h1:IPD3fr1CTTtpT5Z7udPfQgawCyHsWK9vytFHaBLjIUI=
-github.com/kubeflow/kubeflow/components/notebook-controller v0.0.0-20220728153354-fc09bd1eefb8/go.mod h1:ROs2it0U7gdZQGoUNHG5XfhfBmkb5FV2uaJD2Sr8E+Y=
 github.com/mailru/easyjson v0.7.7 h1:UGYAvKxe3sBsEDzO8ZeWOSlIQfWFlxbzLZe7hwFURr0=
 github.com/mailru/easyjson v0.7.7/go.mod h1:xzfreul335JAWq5oZzymOObrkdz5UnU4kGfJJLY9Nlc=
 github.com/matttproud/golang_protobuf_extensions/v2 v2.0.0 h1:jWpvCLoY8Z/e3VKvlsiIGKtc+UG6U5vzxaoagmhXfyg=