[RHOAIENG-29976] bump the envtest and go controller tools version

Since we moved to golang 1.24, we can now use the latest setup-envtest

https://github.com/kubernetes-sigs/controller-runtime/blob/948d554cd9c7692f21139384afaafaea8524626f/tools/setup-envtest/README.md

Author: jstourac

components/notebook-controller/Makefile

@@ -104,7 +104,7 @@ docker-build-multi-arch: ##  Build multi-arch docker images with docker buildx
 
 
 .PHONY: docker-build-push-multi-arch
-docker-build-push-multi-arch: ## Build multi-arch docker images with docker buildx and push to docker registry 
+docker-build-push-multi-arch: ## Build multi-arch docker images with docker buildx and push to docker registry
 	cd .. && docker buildx build --platform ${ARCH} --tag ${IMG}:${TAG} --push -f ./notebook-controller/Dockerfile .
 
 
@@ -143,15 +143,15 @@ $(LOCALBIN): ## Ensure that the directory exists
 CONTROLLER_GEN = $(LOCALBIN)/controller-gen
 .PHONY: controller-gen
 controller-gen: ## Download controller-gen locally if necessary.
-	GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.16.3
+	GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.18.0
 
 KUSTOMIZE = $(shell pwd)/bin/kustomize
 .PHONY: kustomize
 kustomize: ## Download kustomize locally if necessary.
 	$(call go-get-tool,$(KUSTOMIZE),sigs.k8s.io/kustomize/kustomize/[email protected])
 
 ENVTEST = $(shell pwd)/bin/setup-envtest
-ENVTEST_VERSION?=v0.0.0-20240923090159-236e448db12c
+ENVTEST_VERSION?=v0.0.0-20250723164028-948d554cd9c7
 
 .PHONY: envtest
 envtest: ## Download setup-envtest locally if necessary.

components/odh-notebook-controller/Makefile

@@ -12,7 +12,9 @@ KF_TAG ?= $(KF_TAG)
 CONTAINER_ENGINE ?= podman
 
 # ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
-ENVTEST_K8S_VERSION = 1.26
+# We should try to use the kubernetes version that is used in the oldest OpenShift we support: https://access.redhat.com/solutions/4870701
+# Right now we target the OCP 4.15 as the oldest one: https://access.redhat.com/articles/rhoai-supported-configs
+ENVTEST_K8S_VERSION = 1.28
 
 # Kubernetes configuration
 K8S_NAMESPACE ?= odh-notebook-controller-system
@@ -232,17 +234,19 @@ $(LOCALBIN): ## Ensure that the directory exists
 CONTROLLER_GEN = $(LOCALBIN)/controller-gen
 .PHONY: controller-gen
 controller-gen: ## Download controller-gen locally if necessary.
-	GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.16.3
+	GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.18.0
 
 KUSTOMIZE = $(LOCALBIN)/kustomize
 .PHONY: kustomize
 kustomize: ## Download kustomize locally if necessary.
 	GOBIN=$(LOCALBIN) go install sigs.k8s.io/kustomize/kustomize/[email protected]
 
 ENVTEST = $(LOCALBIN)/setup-envtest
+ENVTEST_VERSION?=v0.0.0-20250723164028-948d554cd9c7
+
 .PHONY: envtest
-envtest: ## Download setup-envtest locally if necessary.
-	GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240923090159-236e448db12c
+envtest: ## Download setup-envtest locally if necessary - https://pkg.go.dev/sigs.k8s.io/controller-runtime/tools/setup-envtest#section-readme
+	GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@$(ENVTEST_VERSION)
 
 KTUNNEL = $(LOCALBIN)/ktunnel
 .PHONY: ktunnel