Skip to content

Commit c9488b1

Browse files
authored
remove ACK_GINKGO_DEPRECATIONS=1.16.5 env var in make test (#650)
Co-authored-by: Adam David Maly <[email protected]>
1 parent 5db657d commit c9488b1

File tree

1 file changed

+0
-2
lines changed
  • components/odh-notebook-controller

1 file changed

+0
-2
lines changed

components/odh-notebook-controller/Makefile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,12 +93,10 @@ vet: ## Run go vet against code.
9393
test: test-with-rbac-false test-with-rbac-true
9494
test-with-rbac-false: manifests generate fmt vet envtest ## Run tests.
9595
export SET_PIPELINE_RBAC=false && \
96-
ACK_GINKGO_DEPRECATIONS=1.16.5 \
9796
KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) -p path)" \
9897
go test ./controllers/... -ginkgo.v -ginkgo.progress -test.v -coverprofile cover-rbac-false.out
9998
test-with-rbac-true: manifests generate fmt vet envtest ## Run tests.
10099
export SET_PIPELINE_RBAC=true && \
101-
ACK_GINKGO_DEPRECATIONS=1.16.5 \
102100
KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) -p path)" \
103101
go test ./controllers/... -ginkgo.v -ginkgo.progress -test.v -coverprofile cover-rbac-true.out
104102

0 commit comments

Comments
 (0)